Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra features {rotation, colour inversion, b&w conversion} #11

Open
lovemeblender opened this issue Nov 2, 2015 · 5 comments
Open

Comments

@lovemeblender
Copy link

It would be nice to add some extra features such as rotation, colour inversion or b&w conversion.

@asafyish
Copy link

asafyish commented Nov 3, 2015

It think it's better if image manipulation will be on the source image, there is a large amount of tools for that (lwip, jimp, camanjs). img2css should be focused on 1 thing. img-2-css.

@lovemeblender
Copy link
Author

There are two important reasons in favor of this enhancement:

  1. Say that you generate a CSS picture using img2css and then you need to rotate it. Why would you go back to the original picture, rotate it and then generate the CSS again? What if you need to do several manipulations?
  2. Performing the manipulations on the CSS side is going to be faster than working directly on the image.

On top of that, img2css seems to be gaining popularity. It would be nice to give more life to this project by extending its main functionality.

@ghost
Copy link

ghost commented Nov 4, 2015

Use CSS to rotate it :P

@javierbyte
Copy link
Owner

@lovemeblender,

I agree with @asafyish and @s3r1alpari4h, I think that img2css should focus on the conversion.

But you are right in the need to be able to extend the core functionality, what do you think about adding something where you can manipulate the image data without needing to read the image from a canvas? That way you can add as many filters as you want, without having to include those filters to the core.

@lovemeblender
Copy link
Author

Are you suggesting directly manipulating the RGB array as in base64ImageToRGBArray.js ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants