Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should be using the MD5sum HTTP response header for wget-finder #14

Open
rweichler opened this issue Mar 13, 2015 · 1 comment
Open

Comments

@rweichler
Copy link

I'm pretty sure most HTTP servers support just returning the MD5sum of a file, so you can just request that instead of downloading the whole file and MD5summing it locally (and wasting bandwidth/time).

I might make a PR of this tomorrow if I have time

really good idea, btw! saw this on HN

@javier-lopez
Copy link
Owner

Thanks for commenting, indeed, wget-finder could be smarter about it, it could check the Content-MD5 tag whenever it's available (and whenever wget supports the -S flag, the busybox version doesn't), it could also try to guess md5sum files placed side by side to the target file.

If you don't have time soon, I'll give it a try the next time I touch the code, thanks for the idea =)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants