Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage #820

Open
ftomassetti opened this issue Mar 4, 2017 · 11 comments · May be fixed by #4181
Open

Increase code coverage #820

ftomassetti opened this issue Mar 4, 2017 · 11 comments · May be fixed by #4181
Labels
Easy An ideal bug for somebody new to the project to take on! Improvement Not a bug, but a way that JP can be be enhanced to work better.

Comments

@ftomassetti
Copy link
Member

We have currently a code coverage of ~60%. We could look into increasing it, perhaps focusing on low hanging fruits. I do not think it makes sense to aim at a very high value but I suppose that with a limited effort we could move the needle.
@matozoid
Copy link
Contributor

matozoid commented Mar 4, 2017

Shall I tag this "easy"?

@ftomassetti
Copy link
Member Author

Yes, I think many tests would be easy to write. Maybe we should just point to where to read the code coverage.

@matozoid matozoid added the Easy An ideal bug for somebody new to the project to take on! label Mar 4, 2017
@matozoid matozoid added Improvement Not a bug, but a way that JP can be be enhanced to work better. and removed General request labels Sep 11, 2017
@matozoid
Copy link
Contributor

matozoid commented Nov 3, 2017

Some thoughts:

  • I'm not sure the code generated by JavaCC is included correctly. We never seem to get much above 60%
  • a lot of code in src/main/java is generated by us. I don't feel a need to test all of it, so coverage will never be high

@MysterAitch MysterAitch mentioned this issue Jan 25, 2019
Closed
@JulienVig
Copy link

Hi! Is this issue still open?

@matozoid
Copy link
Contributor

Yeah, a few more tests are always welcome!

@AnnaSkantz
Copy link

Hi,
We are a group of students who would like to work on this issue as part of a group assignment.

@jlerbsc
Copy link
Collaborator

jlerbsc commented Feb 26, 2022

Hi @AnnaSkantz you can submit PR as you wish!

@ghost
Copy link

ghost commented Oct 13, 2022

Hello, some other students and I would like to work on this for a university project. What would be some good code for us to test and can we get this issue assigned to us? Or should we just submit a PR with our additions without this issue getting assigned?

@jlerbsc
Copy link
Collaborator

jlerbsc commented Oct 13, 2022

You can indeed propose improvements. Thank you for asking the problem you are encountering or trying to solve.

@ghost ghost mentioned this issue Oct 25, 2022
Closed
@ameliagenova ameliagenova mentioned this issue Oct 29, 2022
Merged
@YinyinChencr7
Copy link

Hi, can I work on this issue?

@jlerbsc
Copy link
Collaborator

jlerbsc commented Oct 18, 2023

Your help will be appreciated.

This was referenced Oct 28, 2023
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy An ideal bug for somebody new to the project to take on! Improvement Not a bug, but a way that JP can be be enhanced to work better.
Projects
None yet
Milestone
No milestone
6 participants
@matozoid @ftomassetti @jlerbsc @JulienVig @AnnaSkantz @YinyinChencr7