Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR / Issue templates #3104

Open
MysterAitch opened this issue Feb 21, 2021 · 1 comment · May be fixed by #3105
Open

PR / Issue templates #3104

MysterAitch opened this issue Feb 21, 2021 · 1 comment · May be fixed by #3105
Labels
housekeeping issues relating to e.g. dependency updates or coding standards or test coverage Improvement Not a bug, but a way that JP can be be enhanced to work better.

Comments

@MysterAitch
Copy link
Member

We currently have a fairly basic PR template in place:

https://github.com/javaparser/javaparser/blob/master/PULL_REQUEST_TEMPLATE.md

Let's improve this :)
MysterAitch added a commit that referenced this issue Feb 21, 2021
@MysterAitch
Update PULL_REQUEST_TEMPLATE.md
c9de2d3 
Here is a short proposal for #3104 .

I don't want it to be overly rigid/bureaucratic or otherwise get in the way.

Instead, just act as a reminder for common things to look out for (e.g., ensuring that changes to one solver have been made in all solvers to keep them in sync where possible).

Comments/changes/objections/alternative proposals etc. are all appreciated!
@MysterAitch MysterAitch linked a pull request Feb 21, 2021 that will close this issue
Draft
@MysterAitch MysterAitch linked a pull request Feb 21, 2021 that will close this issue
Proposal -- Update PULL_REQUEST_TEMPLATE.md #3105
Draft
@MysterAitch
Copy link
Member Author

I was going to add a comment here, but instead draft PR #3105 is probably a better way to share a work in progress / suggested tweak.

@MysterAitch MysterAitch added Improvement Not a bug, but a way that JP can be be enhanced to work better. builds / releases issues relating to building or releasing javaparser housekeeping issues relating to e.g. dependency updates or coding standards or test coverage and removed builds / releases issues relating to building or releasing javaparser labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping issues relating to e.g. dependency updates or coding standards or test coverage Improvement Not a bug, but a way that JP can be be enhanced to work better.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proposal -- Update PULL_REQUEST_TEMPLATE.md javaparser/javaparser
1 participant
@MysterAitch