You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I'm raising an issue mostly to gather advice and then invest the time to fix it myself since I've been getting so much use out of this plugin and really it is the only viable option on the JavaFX + Maven side of things right now. (thank you very much btw)
I'm generally referring to at least JDK 10 here, and most likely JDK 11 as well but have not tried it though although I see no reason why it would be magically fixed in the subsequent release anyway.
Here goes :
let's say you have a maven project with 3 modules as :
---- parent
|----- app
|----- api commons
|----- api server
Now the only think you want to package is the app module, which depends on the api commons module here. But you might want to package any arbitrary submodule.
Right now I have both the api commons and api server fully under JPMS (using module path and all that fun stuff), and can also run the app itself with full JPMS usage (again, using module-path rather than unnamed compatibility).
But when running the maven plugin like I'm used to (through mvn jfx:native), it doesn't generate installers while without the whole module path setup, it works fine.
Also works fine with its dependencies (api commons here) using module path.
Just the final packaged project cannot be (or I messed up, at the very least) packaged if using JPMS fully.
I have seen a few examples of workaround in the issues of the project (like specifying module item in the plugin config) but nothing regarding multi-module projects, and these did not succeed.
Now the idea would be to at least find and document a workaround or inquire on what the issue is and fix it (cannot be that dramatic if we're honest, maybe just not having the main class open or something is the issue).
Thank you, and hoping we can fix that 👍
The text was updated successfully, but these errors were encountered:
Hello, I'm raising an issue mostly to gather advice and then invest the time to fix it myself since I've been getting so much use out of this plugin and really it is the only viable option on the JavaFX + Maven side of things right now. (thank you very much btw)
I'm generally referring to at least JDK 10 here, and most likely JDK 11 as well but have not tried it though although I see no reason why it would be magically fixed in the subsequent release anyway.
Here goes :
let's say you have a maven project with 3 modules as :
Now the only think you want to package is the app module, which depends on the api commons module here. But you might want to package any arbitrary submodule.
Right now I have both the api commons and api server fully under JPMS (using module path and all that fun stuff), and can also run the app itself with full JPMS usage (again, using module-path rather than unnamed compatibility).
But when running the maven plugin like I'm used to (through
mvn jfx:native
), it doesn't generate installers while without the whole module path setup, it works fine.Also works fine with its dependencies (api commons here) using module path.
Just the final packaged project cannot be (or I messed up, at the very least) packaged if using JPMS fully.
I have seen a few examples of workaround in the issues of the project (like specifying module item in the plugin config) but nothing regarding multi-module projects, and these did not succeed.
Now the idea would be to at least find and document a workaround or inquire on what the issue is and fix it (cannot be that dramatic if we're honest, maybe just not having the main class open or something is the issue).
Thank you, and hoping we can fix that 👍
The text was updated successfully, but these errors were encountered: