Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check requires '.html' extension and skips all pages #742

Open
gwern opened this issue Nov 29, 2019 · 1 comment · Fixed by #973
Open

Check requires '.html' extension and skips all pages #742

gwern opened this issue Nov 29, 2019 · 1 comment · Fixed by #973

Comments

@gwern
Copy link
Contributor

gwern commented Nov 29, 2019

I was testing out check; apparently I have been using it wrong because running check before compilation does nothing (and yields no warning or error) and you're supposed to run it after. The doc doesn't tell you anything about how to run it. It also appears to have some encoding issues:

...
Checking file _site/docs/sunkcosts/index.html
Checking file _site/docs/sunkcosts/2015-danielmead-alwaysastarterneverafinisher.html
hakyll: _site/docs/personal/2012-gwern-personalityproject.html: hGetContents: invalid argument (invalid byte sequence)
Checking file _site/docs/index.html
Checking file _site/docs/personal/aotdisposition_process.html
...

The HTML file in question does declare its text type:

<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">

Anyway, the big problem here is that when I check internal links, it seems to be checking only files with the .html extension. As I use extension-less URLs, this means it skips all of my pages and only covers stuff I generated as redirects or the occasional HTML archive/mirror page. It would make more sense to check all generated HTML files.

@Minoru
Copy link
Collaborator

Minoru commented Apr 4, 2023

it seems to be checking only files with the .html extension

This is addressed by #973, just change checkHtmlFile in your Hakyll config.

I'll keep this issue open because the other two problems still exist.

@Minoru Minoru reopened this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants