Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Ouch!) All variables in Game.js are global #25

Open
vicksonzero opened this issue Apr 13, 2015 · 1 comment
Open

(Ouch!) All variables in Game.js are global #25

vicksonzero opened this issue Apr 13, 2015 · 1 comment
Labels
help wanted refactor

Comments

@vicksonzero
Copy link
Collaborator

ouch... looks like all variables miss the keyword this. before them, thus making all of them global. need some serious clean up
@vicksonzero
Copy link
Collaborator Author

fine.... due to time limit, this will become a known bug for now

@vicksonzero vicksonzero changed the title [Severe] All variables in Game.js are global (Ouch!) All variables in Game.js are global May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonycw @vicksonzero