Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable defaults #37

Open
enstyled opened this issue Mar 22, 2024 · 3 comments
Open

Configurable defaults #37

enstyled opened this issue Mar 22, 2024 · 3 comments

Comments

@enstyled
Copy link
Contributor

All the query parameters have default values! It would be great if these defaults can be configured with environment variables, e.g. DEFAULT_WIDTH, DEFAULT_VIEWPORT_HEIGHT, etc.

@jasonraimondi
Copy link
Owner

Oh nice yeah good idea, that would be an easy follow up

@enstyled
Copy link
Contributor Author

@jasonraimondi thank you for looking into this! I could not find how to use these options. Happy to help with updating the docs, if you point me to the implementation.

@jasonraimondi
Copy link
Owner

Oh shoot I accidentally thought this was one of my “brainstorming” issues that had (like #39). I have not implemented this one yet (mostly because I forgot) but would definitely accept a PR for any of these improvements. I can try and get this issue worked on soon now that I remember it is a real request from an end user.

@jasonraimondi jasonraimondi reopened this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants