Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Color ANSI codes not rendering with latest version of Ink #310

Open
royvandewater opened this issue Jul 30, 2018 · 2 comments
Open

Color ANSI codes not rendering with latest version of Ink #310

royvandewater opened this issue Jul 30, 2018 · 2 comments

Comments

@royvandewater
Copy link

royvandewater commented Jul 30, 2018

When using the latest version of ink, ansi color codes from ultra test output render as their escape values, rather than the colors. Downgrading Ink to 0.9.0 fixes this issue. It looks like they switched to a new ANSI conversion library in this commit.

I'm not sure if the problem is in proto-repl, but I figured you might be able to help point me in the right direction. Colors from proto-repl output seem to render fine (like the blue in Refreshing code...).

Example Output

Refreshing code...
No user namespace defined. Defaulting to clojure.tools.namespace.repl/refresh.

:reloading (ink-example.show-ansi-problem-test)
Refresh complete

Testing ink-example.show-ansi-problem-test
�[31m
FAIL�[0m in (show-error) (show_ansi_problem_test.clj:50)
when the test is called and destined to fail

expected: �[31m(�[0m�[34mtrue?�[0m �[36mfalse�[0m�[31m)�[0m
  actual: �[36mfalse�[0m

Ran 1 tests containing 3 assertions.
1 failures, 0 errors.
ink-example.show-ansi-problem-test=>
{:type :summary, :fail 1, :error 0, :pass 2, :test 1}

Package Versions

proto-repl 1.4.24
ink 0.9.2
ultra 0.5.2
clojure 1.8.0
lein 2.8.1
java 1.8.0_171
@royvandewater
Copy link
Author

Looks like this was fixed here JunoLab/atom-ink#175. They do mention that they're moving to a new version of console and that the current one won't be maintained for much longer.

@royvandewater
Copy link
Author

Nevermind, looks like it's still happening :-/

@royvandewater royvandewater reopened this Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant