Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the way providers resolve toggle key names. #165

Open
Bunabun opened this issue Sep 29, 2018 · 0 comments
Open

Allow overriding the way providers resolve toggle key names. #165

Bunabun opened this issue Sep 29, 2018 · 0 comments

Comments

@Bunabun
Copy link

Bunabun commented Sep 29, 2018

It'd be nice if AppSettingsProvider, BooleanSqlServerProvider, ect. allowed modifying how it determines the key for a feature toggle. Right now it uses the class name and there are situations where being bound to the class name is inconvenient (friendly names or enum based feature toggle).
The logic can be placed in a protected virtual method or a function could be passed into the constructor. I suggest using a virtual method to keep the constructor simple as the providers don't necessarily depend on the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant