New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ConfigurationRoot to Configuration in AppSettingsProvider #159

Open

CumpsD opened this issue May 21, 2018 · 1 comment

Milestone

CumpsD commented May 21, 2018

In .NET Core 2.0 it is advised to switch to IConfiguration:
https://docs.microsoft.com/en-us/aspnet/core/migration/1x-to-2x/?view=aspnetcore-2.0#add-configuration-providers

This means there is no IConfigurationRoot anymore to pass to AppSettingsProvider
https://github.com/jason-roberts/FeatureToggle/blob/master/src/FeatureToggle.Shared/Internal/AppSettingsProvider.cs#L32

jason-roberts added this to the Version 5 milestone

Owner

jason-roberts commented Jun 1, 2018

Thanks @CumpsD - we'll look at this in v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment