Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_.min and _.max can combine #2530

Closed
ahonn opened this issue May 5, 2016 · 2 comments
Closed

_.min and _.max can combine #2530

ahonn opened this issue May 5, 2016 · 2 comments

Comments

@ahonn
Copy link
Contributor

ahonn commented May 5, 2016

I find _.max and _.min have a lot of duplicate code, different only Infinity and - Infinity.
So I don't know why not combine _.max and _.min, create function like createMaxOrMin.
@megawac
Copy link
Collaborator

megawac commented May 5, 2016 •
edited

#2142 (ping @jridgewell)

@megawac megawac closed this as completed May 5, 2016
@ahonn
Copy link
Contributor Author

ahonn commented May 5, 2016

I had seen, but I still don't understand why don't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@megawac @ahonn