Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for IE < 11 #2325

Open
jdalton opened this issue Oct 21, 2015 · 7 comments
Open

Drop support for IE < 11 #2325

jdalton opened this issue Oct 21, 2015 · 7 comments

Comments

@jdalton
Copy link
Contributor

jdalton commented Oct 21, 2015

Tie-in issue to Backbone issue #3828.

On Jan 12, 2016 MS is essentially dropping support for IE8. With that in mind jQuery and Lodash are dropping IE8 support in their 3.0 and 4.0 releases. So let's discuss dropping it in the next major bump of Underscore.

@akre54
Copy link
Collaborator

akre54 commented Oct 22, 2015

👍 What would that entail? Object.create is finally supported, as are most of the Array.prototype methods, but we dropped those already.

@jdalton
Copy link
Contributor Author

jdalton commented Oct 22, 2015

It would mean dropping hasEnumBug fixes in _.keys and _.allKeys, dropping the shift and splice fixes in the array wrapper assignments, dropping the isArguments fallback, and simplifying isArray.

@akre54
Copy link
Collaborator

akre54 commented Oct 22, 2015

In theory I'm in favor. You probably should be using es5shim/es5sham if you need the older browsers anyways.

@jridgewell
Copy link
Collaborator

👍

@jdalton
Copy link
Contributor Author

jdalton commented Oct 22, 2015

In theory I'm in favor. You probably should be using es5shim/es5sham if you need the older browsers anyways.

That's how I'm approaching it with Lodash. I make sure that my usage has a compat path with es5shim and es6shim. I assume folks wanting older IE support will be using those already.

@ghost
Copy link

ghost commented Feb 11, 2020

Is there a living document somewhere that states what browsers are supported by Underscore?

@jgonggrijp jgonggrijp changed the title dropping IE8 support Drop support for IE < 11 Dec 13, 2020
@jgonggrijp
Copy link
Collaborator

Reminder to self: _.delay is essentially a ponyfill for setTimeout in IE < 10 (where setTimeout doesn't support passing additional arguments), so it can be changed into just an alias to setTimeout when we implement this.

@jehrenzweig

Is there a living document somewhere that states what browsers are supported by Underscore?

Since version 1.12, there is: https://underscorejs.org/#compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants