Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id="background" #391

Open
cancerberoSgx opened this issue Apr 25, 2018 · 1 comment
Open

id="background" #391

cancerberoSgx opened this issue Apr 25, 2018 · 1 comment

Comments

@cancerberoSgx
Copy link

If you create a section named "Background", which I think is very common, then docco will break styles because it will create the html <h3 id="background">Background</h3> which collides with docco layout element <div id="background"></div>

This also could happen with <div id="container"></div>

I think the easier solution here is to prefix docco's ids and classes with docco- or something like that (just don't use common words), example: <div id="docco-background"></div>

Unfortunately I'm short of time for fixing this right now, but I will love to do it in the following weeks since this is such a great tool!

Thanks, keep it up!

@jashkenas
Copy link
Owner

We should just always use classes instead of ids. Feel free to send a pull request for this, and I'll merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants