Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow classic jump list to scroll and fix div tag #308

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Truffula
Copy link

Updated to match the fixed version from the parallel layout. Also
discovered a </div> tag was missing.
Fixes #302.

Updated to match the fixed version from the parallel layout. Also
discovered a `</div>` tag was missing.
Fixes jashkenas#302.
In the output html files, any directory separators will be replaced
with underscores (rather than replicating the folder structure, which
would create unnecessary headaches with linking). Fixes jashkenas#309, fixes
jashkenas#303. Also includes some previous changes that were in
`docco.litcoffee` but hadn’t found their way into `docco.js`.
Theoretically it would still create a naming conflict in cases where
you had two files, `foo_bar.coffee` and `foo/index.coffee` which could
be precluded with a double-underscore or similar, but I don’t think
there’s a strong likelihood of that occurring.
Applied change from previous commit (re: jashkenas#309 and jashkenas#303) to the classic
and linear templates.

I’m not sure if some people have a preference for just showing the
basename, but that option isn’t really compatible with multi-directory
sites. For single-folder sites (say, if everything is in `app/`, and
you don’t want `app/` at the front of all your links) you can get
around it simply by running docco from within the folder containing the
files (at least with the CLI).
@Truffula
Copy link
Author

Now includes updates to output file paths (and links) for multi-directory sites.

Makes all links accessible on large sites. Additional change for jashkenas#302.
@keithamus
Copy link
Collaborator

Looks like a good change to me, but I'd like @jashkenas to take a look and do the merge

@Truffula
Copy link
Author

Hi @jashkenas, have you had a chance to have a look at this PR yet?

@jashkenas
Copy link
Owner

I haven't. Got a screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large projects don't fit in the jumpTo menu
3 participants