Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS support broken, please revert patch #293

Open
penx opened this issue Jul 14, 2014 · 4 comments
Open

LESS support broken, please revert patch #293

penx opened this issue Jul 14, 2014 · 4 comments

Comments

@penx
Copy link

penx commented Jul 14, 2014

Please revert #251 as it has broken LESS support added in #136

As far as I can tell, the 'typo' mentioned in #251 is not a typo. Hightlight.js does not support LESS, so the SCSS parser is used, as mentioned in #136.

@kevinsimper
Copy link

How can less be wrong that is should parse with Less? sccs is different from less.

@penx
Copy link
Author

penx commented Sep 9, 2014

They are similar enough that the SCSS parser can be used for docco (at least, that was the intention of #136). If there was an LESS parser for Highlight.js, it could be used. There isn't one, so #251 breaks LESS support.

@keithamus
Copy link
Collaborator

@penx if you make a PR to correct it, I'll merge. If you wanted to be really awesome though, you could push this to get merged instead: highlightjs/highlight.js#558. Then everyone wins.

@mercmobily
Copy link
Contributor

highlightjs/highlight.js#558 was actually merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants