Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about automatic commit message style validation? #4065

Closed
alisianoi opened this issue Aug 15, 2016 · 1 comment
Closed

How about automatic commit message style validation? #4065

alisianoi opened this issue Aug 15, 2016 · 1 comment

Comments

@alisianoi
Copy link

If you look at commit history of projects like agnuar.js or jquery, you will notice that they use a consistent commit message style. Would you perhaps like to do the same?

One way to support a single commit message style is to have git perform the check via a hook, like so:

record_ember

The process shown above is done via an npm module commitplease (npm, github). It checks your commit message and tells you if it is a poor one (long lines, bad first line and so on). Commitplease is used by jQuery Core, jQuery UI, jQuery Mobile, Globalize, QUnit and others. It is as simple as

npm install commitplease --save-dev

If you are interested, let me know what you think. Disclaimer: I help develop commitplease.

@akre54
Copy link
Collaborator

akre54 commented Aug 15, 2016

This seems like a lot of overhead for little gain. A good chunk of our pull requests come from developers new to Git / Github. I don't think we want to add yet another barrier to entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants