Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAV loop points are not automatically applied #318

Open
Kermalis opened this issue Apr 25, 2021 · 0 comments
Open

WAV loop points are not automatically applied #318

Kermalis opened this issue Apr 25, 2021 · 0 comments

Comments

@Kermalis
Copy link

Expected behavior:

A wav file with loop points embedded should automatically set the correct sample to loop to.

Actual behavior:

The WavStream still loops from sample 0, ignoring the loop start marker in the file. Instead, math is needed to manually calculate the loop point in seconds. Seconds are inaccurate and causes gaps because it's not specific enough, especially with infinite decimal points involved. If the exact sample was used, then we wouldn't need to calculate seconds with all of the timing involved.

For example, a song at 110BPM, with 4/4 time signature, that should loop after 14 bars will place the loop at 30.5454~ seconds. This causes SoLoud to create a gap between the end and the loop even though the loop should be perfect. Given that we can easily embed the loop points in the wav, they should be used.

Seconds are just not accurate enough, when we can use exact samples from the file itself. Easier for everyone involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant