Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble fetching device market names #19

Open
Zishan3165 opened this issue Apr 9, 2018 · 1 comment
Open

Trouble fetching device market names #19

Zishan3165 opened this issue Apr 9, 2018 · 1 comment

Comments

@Zishan3165
Copy link

Zishan3165 commented Apr 9, 2018

I'm having trouble fetching some market names of the phones where the model is returned
When I view the raw JSON it shows that the market_name exists but in code it comes off same as the model.

{
"manufacturer": "Xiaomi",
"market_name": "HM Note 2",
"codename": "hermes",
"model": "Redmi Note 2"
}

eg

DeviceName.with(this).request { info, error ->
            val manufacturer = info.manufacturer 
            val name = info.marketName
            val model = info.model
            val codename = info.codename
            val deviceName = info.name

Here, the name returns Redmi Note 2 (should return HM Note 2) and model also returns Redmi Note 2

@jaredrummler
Copy link
Owner

It looks like both QUBO and Xiaomi have a device with the codename hermes. However, I don't see Redmi Note 2 used as a market_name anywhere. Are you sure you using the marketName and not the model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@jaredrummler @Zishan3165 and others