Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] More user-friendly Sidecar containers support #276

Open
gazarenkov opened this issue Mar 26, 2024 · 0 comments
Open

[Proposal] More user-friendly Sidecar containers support #276

gazarenkov opened this issue Mar 26, 2024 · 0 comments
Labels
jira Issue will be sync'ed to Red Hat JIRA kind/feature

Comments

@gazarenkov
Copy link
Collaborator

Simplify supporting adding sidecar containers to Backstage deployment.

Example: adding OAuth2 Proxy for Keyclock support as described in https://janus-idp.io/blog/2023/01/17/enabling-keycloak-authentication-in-backstage .

Context: it is possible to define any deployment configuration redefining deployment.xml in:

  • default configuration (cluster scope)
  • raw CR configuration (instance scope)
    but for the time user have to define the whole deployment.yaml manifest which is some big

Proposals:

There are 2 reasonable way to simplify it, we can consider both (one does not exclude other):

  1. Just to address this problem: add necessary sidecar(s) to default deployment.yaml but consider it disabled by default (operator will exclude all but mandatory backstage and init container runtime) and make an option in CR to enable sidecars, e g: Backstage.spec.enableSidecars=true|[false]
  2. Generic solution, which could address other problems requiring "slight changes" of configuration (like this Permission issues on mounted Volumes for RHDH container #254 ): supporting patches for default/raw configuration. This way user/admin will be able to add any missing pieces for particular cluster/instance with proposing merging patch. Technical Proposal will come in other issue.
@github-actions github-actions bot added the jira Issue will be sync'ed to Red Hat JIRA label Mar 26, 2024
@gazarenkov gazarenkov changed the title More user-friendly Sidecar containers support [Proposal] More user-friendly Sidecar containers support Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira Issue will be sync'ed to Red Hat JIRA kind/feature
Projects
None yet
Development

No branches or pull requests

1 participant