Add a new tab to the EntityPage for the Quarkus console #1154
Conversation
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
|
The image is available at: |
There was a problem hiding this comment.
2 remarks here:
- Do you think you could create a dedicated PR for the Docs enhancement ?
- With dynamic plugins, we should not require changing the source code of the frontend application in order to wire a dynamic plugin. That seems like an anti-pattern. Users of the showcase that will want to bring their own plugins in a dedicated tab will not be able to change the showcase image . @tumido @gashcrumb Any idea about how to contribute a new tab ? I assume we should have something, right ?
And if not the it seems to me it would be quite urgent to open an issue and plan it. |
I fully agree with you but my PR has been created based on discussions with @gashcrumb as currently this is the only way to add a tab |
I can do that but then it will be needed to remove commits pushed on this PR .... |
I did a test on our cluster using the image of the PR and that works too. |
I assume this PR should be rebased yes, or possibly replaced b the new one. BTW I don't really see the point in adding a TOC, since one is already constructed automatically by GH (as would be in other markdown viewers) based on the Markown structure:
|
My main problem is that it seems to me that we should not need to create a new container image in order to add a tab specific to a dynamic plugin. |
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
I removed the TOC from this PR |
|
So... The code is completely correct and valid. Secondly, you should really think twice before adding new tabs. The fact that you can't just add a new tab by the dynamic plugins mechanism is 100% intentional. Our aim was to always reduce the amount of tabs we provide. We don't want to end up in a situation where we have a new tab per plugin. Each tab should represent a purpose that is generic and common to every entity of the same kind and type in the catalog. That's why we don't have a distinct GitHub Actions tab and Tekton tab -> we have a single CI tab instead. The presence of a new tab should be a PM/UX question, this is not something we should decide only on code quality/review basis. |
I agree with you and that will discussed soon between the Quarkus's Product Manager and RHDH team. FYI: The Quarkus Console plugin could become (if approved by the different Runtime PMs) a runtime plugin supporting: Quarkus, Spring Boot, EAP, etc java runtimes |
I think that even this assertion should be validated by PM / UX. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
The image is available at: |
|
Like Tom mentioned, I agree that we should not ship too many tabs by default. We've been focusing a lot on the Component kind where most of the tabs are already present, but if someone would like to add more tab to the user, groups or custom Kind, currently they are not allowed. |
|
Issue #1160 was opened for this purpose,to avoid fixing this with a plugin-specific fix. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This PR:
./packages/app/src/components/catalog/EntityPage/index.tsxfile in order to allow to display the Quarkus consoleyarn startWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer