Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown commands block program indefinitely #65

Open
paulsonnentag opened this issue May 23, 2018 · 1 comment
Open

Unknown commands block program indefinitely #65

paulsonnentag opened this issue May 23, 2018 · 1 comment

Comments

@paulsonnentag
Copy link
Contributor

Currently if you pass an unknown command to paper.get it blocks the program indefinitely.

const number = await paper.get("paperNumber") // typo, "number" would be correct

Instead I would propose to throw an error in this situation like:

Unrecognized command paper.get("paperNumber", ...)
@janpaul123
Copy link
Owner

Yes! Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janpaul123 @paulsonnentag