Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vue 3 Support? 👀 #38

Closed
janniks opened this issue Jul 21, 2021 · 11 comments · Fixed by #102
Closed

Add Vue 3 Support? 👀 #38

janniks opened this issue Jul 21, 2021 · 11 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request

Comments

@janniks
Copy link
Owner

janniks commented Jul 21, 2021

Hi vue-notion users!

I am thinking about adding support for Vue 3. However, due to tooling and API differences this will be quite complicated. It will likely have to live in its own repo or branch. Also Vue 3 will not be usable with Nuxt, until Nuxt 3 is released.

As soon as Nuxt 3 is released, I will definitely migrate this repo to Vue 3.

Think of this issue as a poll:

  • Vote ♥️ : Add Vue 3 support as its own version (e.g. vue-notion@vue3-0.1.0)
  • Vote 👀 : Wait until Nuxt is compatible with Vue 3

EDIT:
As Vue 3 is now the next hot+stable thing, I'll introduce the Vue 3 compatible version as >= 3.0.0 (skipping 2.0.0) — hopefully soon.... Nuxt 3 isn't quite out yet, but I'll try to make it work 🤷‍♀

@janniks janniks pinned this issue Jul 21, 2021
@janniks janniks added the vote Vote on the future of the project label Aug 2, 2021
@janniks janniks changed the title [VOTE] Add Vue 3 Support Add Vue 3 Support? Sep 4, 2021
@janniks janniks changed the title Add Vue 3 Support? Add Vue 3 Support? 👀 Sep 6, 2021
@CalebKester
Copy link

@janniks just wondering what the status on this is. With Nuxt3 coming out as well as Vue3 with Vite, what do you think about making this a composable for vue3 so it could also be used regardless of vue3 framework?

@yacosta738
Copy link

bitmoji

@paulocastellano
Copy link

What's the status of it?

@rashidpathiyil
Copy link

I want use notion with Nuxt 3.
Please share if you have information that help.

@janniks
Copy link
Owner Author

janniks commented Aug 4, 2022

Looks like Vue 3 is the new standard at this point, so I'll prioritize a switch soon. Will give a status update in two weeks (on vacation currently).

@barisener
Copy link

@janniks any update 👀

@janniks
Copy link
Owner Author

janniks commented Aug 25, 2022

Opened a PR: #102 (still some way to go, especially on the Nuxt front)

Feel free to test the alpha released under 3.0.0-alpha.0 (e.g. npm i vue-notion@3.0.0-alpha.0)

@janniks janniks linked a pull request Aug 25, 2022 that will close this issue
@janniks janniks added enhancement New feature or request and removed vote Vote on the future of the project labels Aug 25, 2022
@janniks janniks self-assigned this Aug 25, 2022
@janniks
Copy link
Owner Author

janniks commented Dec 22, 2022

Sorry, for the delays — 3.0.0-alpha.1 now available, maybe this should work soon 🚀

@iBobik
Copy link

iBobik commented Dec 31, 2022

Trying to use it on Nuxt 3.

When installed it warns about vue-dompurify-html requiring Vue 2:

> npm install vue-notion@^3.0.0-alpha.1 --save-dev
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: vue-dompurify-html@2.6.0
npm WARN Found: vue@3.2.45
npm WARN node_modules/vue
npm WARN   vue@"^3.2.13" from @hsorby/vue3-katex@0.6.0-rc.4
npm WARN   node_modules/@hsorby/vue3-katex
npm WARN     @hsorby/vue3-katex@"^0.6.0-rc.4" from vue-notion@3.0.0-alpha.1
npm WARN     node_modules/vue-notion
npm WARN   9 more (@nuxt/vite-builder, @unhead/vue, @vitejs/plugin-vue, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer vue@"^2.0.0" from vue-dompurify-html@2.6.0
npm WARN node_modules/vue-dompurify-html
npm WARN   vue-dompurify-html@"^2.5.2" from @hsorby/vue3-katex@0.6.0-rc.4
npm WARN   node_modules/@hsorby/vue3-katex
npm WARN 
npm WARN Conflicting peer dependency: vue@2.7.14

Then after start:

 ERROR  Cannot start nuxt:  Cannot read properties of undefined (reading 'options')

  at module.exports (node_modules/vue-notion/nuxt/index.js:9:13)
  at installModule (node_modules/@nuxt/kit/dist/index.mjs:416:9)
  at async initNuxt (node_modules/nuxt/dist/index.mjs:1825:7)
  at async load (node_modules/nuxi/dist/chunks/dev.mjs:6779:9)
  at async Object.invoke (node_modules/nuxi/dist/chunks/dev.mjs:6840:5)0:54:57
  at async _main (node_modules/nuxi/dist/cli.mjs:50:20)

Also using component directly (without Nuxt module) does not work:
Snímek obrazovky 2022-12-31 v 17 32 33

@janniks
Copy link
Owner Author

janniks commented Mar 26, 2023

Vue 3 support in vue-notion is here!

I believe vue-notion@3.0.0-beta.1 is working, so I pushed it to main and released. Still marking as beta for now until the first folks try it out. 🙌

@ebanDev
Copy link

ebanDev commented Nov 28, 2023

That is amazing ! :D Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants