Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed trace files #154

Open
cgaebel opened this issue Apr 15, 2022 · 1 comment
Open

Compressed trace files #154

cgaebel opened this issue Apr 15, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@cgaebel
Copy link
Contributor

cgaebel commented Apr 15, 2022

Trace files are big and compress really well, 5x-ish in my experience. Could magic-trace write out compressed traces instead of raw traces?

Perfetto already has support for loading gzipped traces. But gzip is really slow (fingers crossed for Sapphire Rapids, but that's years from being commonplace).

As far as I can tell, we have two options here:

  • teach magic-trace to write gzipped traces, or
  • teach magic-trace to write zstd'd traces, and also teach perfetto to load them.

The first option is easier, but the second option would be faster to save and load. FWIW, Tudor thinks zstd is overkill because we're so slow at decoding otherwise.

@cgaebel cgaebel added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2022
@Xyene Xyene added this to the v1.1.0 milestone Apr 18, 2022
@Xyene Xyene modified the milestones: v1.1.0, v1.2.0 Jun 1, 2022
@Xyene Xyene modified the milestones: v1.2.0, v1.3.0 Jun 29, 2022
@hlian
Copy link
Contributor

hlian commented Jul 20, 2022

@Lilydemi has a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants