{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":452433468,"defaultBranch":"master","name":"magic-trace","ownerLogin":"janestreet","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-01-26T20:41:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3384712?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708333689.0","currentOid":""},"activityList":{"items":[{"before":"75093473bd63a499090b53dcecd493a83cdc10c1","after":"968ffea4f48216ada9bccc7013ae5d7502f7f3f3","ref":"refs/heads/master","pushedAt":"2024-04-26T06:51:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Fix typo in \"magic-trace.org\"","shortMessageHtmlLink":"Fix typo in \"magic-trace.org\""}},{"before":"35a0fbd4de19bdb84e5698a85abac689f5f2ee20","after":"75093473bd63a499090b53dcecd493a83cdc10c1","ref":"refs/heads/master","pushedAt":"2024-03-03T14:30:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Fix typos\n\nSigned-off-by: int-y1 <jason_yuen2007@hotmail.com>","shortMessageHtmlLink":"Fix typos"}},{"before":"492afe4ada203104e5d74df6b7a501b2b9448558","after":"35a0fbd4de19bdb84e5698a85abac689f5f2ee20","ref":"refs/heads/master","pushedAt":"2024-02-19T08:53:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Be more robust to seeing a poptrap without a matching pushtrap\n\nAlso add more verbose logging for decode errors.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Be more robust to seeing a poptrap without a matching pushtrap"}},{"before":"efe513c3a571524c15835bcf33ebe73ce2a5d6c6","after":"492afe4ada203104e5d74df6b7a501b2b9448558","ref":"refs/heads/master","pushedAt":"2024-02-19T08:52:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Restore default SIGINT behavior after taking snapshot\n\nThis feels like a hack, but it works for now pending discussion with\nasync devs.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Restore default SIGINT behavior after taking snapshot"}},{"before":"bacf0a0469a2f3efc840d41a0cc79d9c9a702193","after":"efe513c3a571524c15835bcf33ebe73ce2a5d6c6","ref":"refs/heads/master","pushedAt":"2024-02-19T08:49:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Don't assume `perf` is still alive after sending it `SIGTERM`\n\nWe caught this in practice with certain builds of `perf`.\n\nThis code seems pretty fishy, and I'd like to look into it further\nlater: it's not obvious to me why `waitpid` would raise if the PID no\nlonger exists. I would have expected `perf` to still be an unreaped\nchild at this point.\n\nBut, we do have ~identical logic in ferrying ^C to `perf` in\n`src/trace.ml` too...\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Don't assume <code>perf</code> is still alive after sending it <code>SIGTERM</code>"}},{"before":"008eca3eafdadaa43de6715f3741a1041272fcea","after":"bacf0a0469a2f3efc840d41a0cc79d9c9a702193","ref":"refs/heads/master","pushedAt":"2024-02-18T00:07:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"build: bust the package cache after upgrading to OCaml 4.14.0","shortMessageHtmlLink":"build: bust the package cache after upgrading to OCaml 4.14.0"}},{"before":"9c9ee066d6123b5919790d5d4ff56e66d3501e90","after":"008eca3eafdadaa43de6715f3741a1041272fcea","ref":"refs/heads/master","pushedAt":"2024-02-17T23:56:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Quote '?' in README.md to avoid shell expansion","shortMessageHtmlLink":"Quote '?' in README.md to avoid shell expansion"}},{"before":"9846bd78e013e443a6ed67a1c2da997585e484f0","after":"9c9ee066d6123b5919790d5d4ff56e66d3501e90","ref":"refs/heads/master","pushedAt":"2024-02-17T23:54:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Upgrade to OCaml 4.14.0\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Upgrade to OCaml 4.14.0"}},{"before":"3b73ef983693fe6c3777f3d25f4a214da5997224","after":"9846bd78e013e443a6ed67a1c2da997585e484f0","ref":"refs/heads/master","pushedAt":"2024-02-17T22:36:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"make it possible to invoke `magic-trace run -- prog args`\n\ninstead of `magic-trace run prog -- args`.\n\nThe current CLI is annoying because you can't just prefix the command\nline with `magic-trace run`, you have to insert of `--` in between\nthe prog and the args.\n\nSigned-off-by: Valentin Gatien-Baron <valentin.gatienbaron@gmail.com>","shortMessageHtmlLink":"make it possible to invoke <code>magic-trace run -- prog args</code>"}},{"before":"1087cbf4888787a6704200e46dffaa50220bfadc","after":"3b73ef983693fe6c3777f3d25f4a214da5997224","ref":"refs/heads/master","pushedAt":"2024-01-10T19:20:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Handle `tr end  async` trace events\n\nKernel commit\n\nhttps://lore.kernel.org/lkml/20230928072953.19369-1-adrian.hunter@intel.com/\n\nset `PERF_IP_FLAG_ASYNC` on trace end events. As per\n\nhttps://github.com/torvalds/linux/blob/7ee022567bf9e2e0b3cd92461a2f4986ecc99673/tools/perf/builtin-script.c#L1546\n\nThis means that where `perf` would have previously outputted\n`tr end  jmp`, it now outputs `tr end  async`.\n\nAdjust our regex to allow `async`, and treat it as a branch.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Handle <code>tr end async</code> trace events"}},{"before":"2fa15738841dd10443a73f7a4d54593bc878ec38","after":"1087cbf4888787a6704200e46dffaa50220bfadc","ref":"refs/heads/master","pushedAt":"2024-01-10T18:58:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Do not display extremely long commandline arguments\n\nOtherwise, the trace writer will raise because we're violating the\nPerfetto trace file format.\n\nI opted to not show the arguments at all because it was slightly\nsimpler, and it is unlikely the 60-something characters Perfetto would\ndisplay in the UI would be particularly enlightening for a commandline\nthat's longer than 32 KiB.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Do not display extremely long commandline arguments"}},{"before":"79a3bba3a9a3100e0fb4465a02c236f4290d1ed0","after":"2fa15738841dd10443a73f7a4d54593bc878ec38","ref":"refs/heads/master","pushedAt":"2024-01-10T18:58:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Fix `-trigger addr:...` selections\n\nThe hex string parsing was reversed.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Fix <code>-trigger addr:...</code> selections"}},{"before":"0dece723bd87663a431ef912c43c1e3bba8c5f9a","after":"79a3bba3a9a3100e0fb4465a02c236f4290d1ed0","ref":"refs/heads/master","pushedAt":"2023-10-28T00:32:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Fix up some messages about sampling wiki links\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Fix up some messages about sampling wiki links"}},{"before":"d390f255f38b2200b7c2bc2bc8137ac952e0075d","after":"0dece723bd87663a431ef912c43c1e3bba8c5f9a","ref":"refs/heads/master","pushedAt":"2023-10-27T23:50:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"README.md: fix light/dark mode logo\n\nI suppose GitHub changed what they accepted for this at some point, but this works now.\r\n\r\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"README.md: fix light/dark mode logo"}},{"before":"d997a232c053b2b9c6526ed22bd840a85272ed17","after":"d390f255f38b2200b7c2bc2bc8137ac952e0075d","ref":"refs/heads/master","pushedAt":"2023-10-27T20:28:16.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Allow `0x`-prefixed addresses to `-trigger addr:`\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Allow <code>0x</code>-prefixed addresses to <code>-trigger addr:</code>"}},{"before":"5b762b0ee47196373f62f8bccd347c2f98f6d9a1","after":"d997a232c053b2b9c6526ed22bd840a85272ed17","ref":"refs/heads/master","pushedAt":"2023-10-27T18:48:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Fix stairstepping OCaml traces when exceptions are involved\n\nThis commit fixes two bugs:\n\n* `caml_raise_exn` modifies the stack and then `ret`s into an\n  `entertrap`, so we need to also do `entertrap` fixups on returns.\n\n* Trap callstacks would often have the symbol of the parent frame\n  re-inferred, which would result in doubling up of that frame. We fix\n  this by seeding the trap callstack with a synthetic frame, which we\n  make sure to delete before outputting trace events.\n\n  A more principled approach would be to have `Callstack` know about\n  traps directly and avoid creating new `Callstack.t`s for them, but\n  that work is deferred to someday that isn't today.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Fix stairstepping OCaml traces when exceptions are involved"}},{"before":"2f9c2aad8a59fe1e6375a509d3f9681d24982823","after":"5b762b0ee47196373f62f8bccd347c2f98f6d9a1","ref":"refs/heads/master","pushedAt":"2023-10-26T19:02:17.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"cgaebel","name":"Clark Gaebel","path":"/cgaebel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/128969?s=80&v=4"},"commit":{"message":"Add explicit tests around bogus symbol offset handling\n\nCloses #269.\nCloses #196.\n\nSigned-off-by: Tudor Brindus <tbrindus@janestreet.com>","shortMessageHtmlLink":"Add explicit tests around bogus symbol offset handling"}},{"before":"9bb5f08c094de05ea79653389bf5fd300862bb4d","after":"2f9c2aad8a59fe1e6375a509d3f9681d24982823","ref":"refs/heads/master","pushedAt":"2023-10-26T17:42:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Xyene","name":"Tudor Brindus","path":"/Xyene","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1403503?s=80&v=4"},"commit":{"message":"Only check for fzf if required to find symbol\n\nnot if symbol is specified by name or defaulted to magic_trace_stop_indicator\n\nFixes #276.\n\nSigned-off-by: Ed Catmur <ed@catmur.uk>","shortMessageHtmlLink":"Only check for fzf if required to find symbol"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEOt5vcgA","startCursor":null,"endCursor":null}},"title":"Activity · janestreet/magic-trace"}