Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete server" button doesn't show properly on macOS #3241

Open
softins opened this issue Feb 27, 2024 · 2 comments
Open

"Delete server" button doesn't show properly on macOS #3241

softins opened this issue Feb 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@softins
Copy link
Member

softins commented Feb 27, 2024

Describe the bug

The "Delete server" button that was added in #3159 doesn't show properly on macOS. At least on my Mac running Catalina 10.15. The button is there, but it is too narrow to show the whole icon.

The button acts correctly when clicked on.

To Reproduce

Download and install a recent build artefact, e.g. from https://github.com/jamulussoftware/jamulus/actions/runs/8031934048. In this case, I installed the Mac Legacy, which had been built with Qt 5.15.2

Expected behavior

The button should be wide enough to show the backspace icon.

Screenshots

image

Operating system

MacOS 10.15 Catalina

Version of Jamulus

3.10.0dev-dbd6e61

Additional context

The button shows correctly on Windows, and when compiled on my Raspberry Pi. I haven't been able to try a more recent MacOS or the non-legacy build.

@softins softins added the bug Something isn't working label Feb 27, 2024
@softins softins added this to the Release 3.11.0 milestone Feb 27, 2024
@ann0see
Copy link
Member

ann0see commented Mar 31, 2024

That's bad. Does the same happen in the server where a comparable button is?

@softins
Copy link
Member Author

softins commented Mar 31, 2024

That's bad. Does the same happen in the server where a comparable button is?

I will look more closely. Checking the various dev versions I have installed, it seems the delete button in the connect dialog shows up ok with Qt 5.9.9, but is truncated as shown above with Qt 5.12 or Qt 5.15. However, in all three cases the delete buttons in the Server Options page show up fine. I'll have to see what the subtle differences are.

@pljones pljones modified the milestones: Release 3.11.0, Release 3.12.0 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triage
Development

No branches or pull requests

3 participants