Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventive maintenance of package #59

Open
alanverresen opened this issue Dec 2, 2023 · 2 comments
Open

Preventive maintenance of package #59

alanverresen opened this issue Dec 2, 2023 · 2 comments

Comments

@alanverresen
Copy link
Contributor

At the moment, it is unclear how this package is being maintained. Everything still seems to work like it should, but there currently aren't any efforts for preventive maintenance to make sure that it stays that way. For example the current tox setup only runs tests for versions of Django that aren't supported anymore.

I'd be happy to help and send a pull request to fix this, and would also like to help in any other way that I can. Can you point out any other parts that I probably also need to take a look at?

@jamesturk
Copy link
Owner

If you'd like to update the tox.ini that'd be nice for others, the most important thing to update would be the GitHub actions test.yaml, appreciate the offer.

@alanverresen
Copy link
Contributor Author

I started working on updating the GitHub actions and tox, but it has turned into somewhat of a complete overhaul. Can you give some feedback on the following things:

  • Are there any particular changes so far that you don't like or have questions about?
  • It seem like you were testing with multiple databases at some point, but it wasn't working with tox/GitHub actions anymore, so I temporarily dropped that part. My next step is to add that back in.
  • Was there a particular reason for using the ./test_run.sh script over an alternative testrunner? It doesn't seem necessary (anymore), but maybe I'm missing something? I'm planning on changing some parts of it, so I don't want to break anything that's not immediately obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants