Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfomance: unnecessary rerendering #63

Open
vanya2h opened this issue Dec 21, 2018 · 1 comment
Open

Perfomance: unnecessary rerendering #63

vanya2h opened this issue Dec 21, 2018 · 1 comment
Labels

Comments

@vanya2h
Copy link

vanya2h commented Dec 21, 2018

Hi. First of all thanks for your work!

But here's i investigate some perfomance issues. I'm currently using why-did-you-render lib and have some interesting warnings:

2018-12-21 13 41 16

(another 3 warns is the same)

I believe react-composer changing component's children more than 1 time so it's produces some unnecessary rendering. Here I have 4 rerenders due to props.children !== prevProps.children

Thanks.

@jamesplease
Copy link
Owner

Hi @kv9991 , I don't have a whole lot of experience with why-did-you-render, so I can't speak much to this. If you have ideas for perf improvements, feel free to suggest them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants