Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feature ] Display the date at which the activity happened #106

Open
CaedenPH opened this issue Jul 13, 2023 · 3 comments
Open

[ Feature ] Display the date at which the activity happened #106

CaedenPH opened this issue Jul 13, 2023 · 3 comments
Labels
feature New feature good first issue Good for newcomers

Comments

@CaedenPH
Copy link

image
Here is an image of recent activity, but it could be helpful to see a date at which this activity happened.

This could be in the form of a formatted date being relative (eg "1 hour ago")
Some examples

  1. 馃殌 Published release v0.4.1 in jamesgeorge007/github-activity-readme 1 hour ago
  2. 馃殌 Published release v0.4.1 in jamesgeorge007/github-activity-readme Today at 7pm

The date could also be in the form of a hyperlink to a website displaying the exact time (eg the emoji could refer to the time and on hover show the time)
I know that when you click on the activity, you can see the time, but it is slightly annoying

@tuunit tuunit added good first issue Good for newcomers feature New feature labels Aug 23, 2023
@tuunit
Copy link
Collaborator

tuunit commented Aug 23, 2023

Hi @CaedenPH,

sounds like a great idea. Please feel free to open a PR for it if you would like to give it a shot.

@CaedenPH
Copy link
Author

@tuunit What formatting and location do you think looks best for the time?

@tuunit
Copy link
Collaborator

tuunit commented Aug 25, 2023

@CaedenPH I personally like how date-fns package does it:
https://date-fns.org/v2.16.1/docs/formatDistance

And regarding the position, your example mockup looks good to me. Just behind the existing text.

The only issue I have with implementing this feature is that the information about the time will always be offset based on the frequency the action is executed and in my opinion GitHubs free resources should not be used to execute a README refresh every minute or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants