Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Flutter 3.7 #325

Open
jamesblasco opened this issue Jan 28, 2023 · 7 comments
Open

Migration to Flutter 3.7 #325

jamesblasco opened this issue Jan 28, 2023 · 7 comments

Comments

@jamesblasco
Copy link
Owner

Hi there,

Flutter 3.7 has been released in Flutter Forward and it comes with several breaking changes that affects modal_bottom_sheet and sheet. I have released a preview package for both that will support this new version of the framework.

I am right now on vacation with no much internet connection but I have done my best to make it work for all you until I can get my hands on it properly.

modal_bottom_sheet:

  • Update to modal_bottom_sheet: ^3.0.0-pre
  • Rename any ModalBottomSheetRoute class reference to ModalSheetRoute

sheet:

  • Update to sheet: ^1.0.0-pre

Once I am back, I will look more closely what can be improved before launching as stable this new mayor version.

Thanks for the understanding!

@jamesblasco jamesblasco pinned this issue Jan 28, 2023
thipokch added a commit to thipokch/unself that referenced this issue Jan 29, 2023
refactor: remove deprecated textstyles
refactor: remove ink_sparkle as fixed by flutter/engine#107438
refactor: remove riso shader due to flutter/engine#34855
bump: modal_bottom_sheet to v3-pre jamesblasco/modal_bottom_sheet#325
thipokch added a commit to thipokch/unself that referenced this issue Jan 29, 2023
refactor: remove deprecated textstyles
refactor: remove ink_sparkle as fixed by flutter/engine#107438
refactor: remove riso shader due to flutter/engine#34855
bump: modal_bottom_sheet to v3-pre jamesblasco/modal_bottom_sheet#325
chore: reenable analyzer for test

fix: FieldType and tests.
@AliPunjabi
Copy link

I am getting this error
Because country_code_picker 2.0.2 depends on modal_bottom_sheet ^2.0.0 and no versions of country_code_picker match >2.0.2 <3.0.0, country_code_picker ^2.0.2 requires modal_bottom_sheet ^2.0.0. So, because <project> depends on both modal_bottom_sheet ^3.0.0-pre and country_code_picker ^2.0.2, version solving failed. pub get failed

@alexda12
Copy link

alexda12 commented Feb 3, 2023

@AliPunjabi This isnt a bug/error in modal_bottom_sheet - The clue is in the useful message that is displayed ... you need to also update your other dependencies...

@mnismt
Copy link

mnismt commented Mar 12, 2023

@AliPunjabi You should update the version of country_code_picker in pubspec.yaml to country_code_picker: ^3.0.0.

@luohao123
Copy link

Hello, Am using modal_bottom_sheet 3.0.0Pre, the code can built, but the animations are gone, when show bottom sheet, there is no animtion!!

@mgaucher
Copy link

Hi, Same problem, animations are gone on Android Samsung galaxy s20, bottom sheet pop from nowhere with showMaterialModalBottomSheet method

@luohao123
Copy link

@jamesblasco Please take a look, thank u!

@nashihu
Copy link

nashihu commented May 15, 2023

hope your vacation goes well @jamesblasco . here now we have flutter 3.10.0 ,, please come back to us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants