Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrulestr not working when using npm install #131

Closed
shavenwalrus opened this issue Feb 16, 2016 · 7 comments
Closed

rrulestr not working when using npm install #131

shavenwalrus opened this issue Feb 16, 2016 · 7 comments

Comments

@shavenwalrus
Copy link

I have done 'npm install rrule'. The files are downloaded in to node_modules, but the lib/rrule.js file is different from the one in the git repository.

Specifically, there is no export for rrulestr (or rruleset).

//=============================================================================
// Export
//=============================================================================

if (serverSide) {
    module.exports = {
        RRule: RRule
        // rruleset: rruleset
    }
}
if (typeof ender === 'undefined') {
    root['RRule'] = RRule;
    // root['rruleset'] = rruleset;
}

if (typeof define === "function" && define.amd) {
    /*global define:false */
    define("rrule", [], function () {
        return RRule;
    });
}
@bholbrook73
Copy link

It's also missing RRuleSet.

@DanielGSan
Copy link

When a update in npm repository to the current version? because is not the same version than here, few missing functions..

@davidfloegel
Copy link

Has there been any fix yet? Tried to use it tonight but no luck... :(

@paulxtiseo
Copy link

paulxtiseo commented Aug 18, 2016

Same issue with on today's npm install. Should we expect a reply?

UPDATE: A quick text diff of the lib/rrule.js and the version offered for download in the README.md (which does export the missing constructs) shows extensive difference in format.

UPDATE 2: While not a good perm solution, if you swap the rrule.js in your node_modules folder with the one downloaded out of the README.md file link, it works.

@karankapur3390
Copy link

Same issue today

@matheusramos
Copy link

Hey guys, I don't know if a new release is coming to npm, so, in the mean time, we can use RRule.fromString("...");

@davidgoli
Copy link
Collaborator

I believe this has been fixed. Let me know if there continue to be issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants