Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sassline mixin ignores the font type. #44

Open
mitchrenton opened this issue May 12, 2016 · 4 comments
Open

Sassline mixin ignores the font type. #44

mitchrenton opened this issue May 12, 2016 · 4 comments

Comments

@mitchrenton
Copy link

I've noticed that the sassline mixin ignores the font type.

For example...

@include sassline(18, $bodytype, 1.5, 1, all);

Outputs

line-height: 1.5rem; font-size: 1.5rem; margin-bottom: 0.74499rem; padding-top: 0.25501rem;

As well as the break point adjustments.

Whilst...

@include sassline(18, $headingtype, 1.5, 1, all);

Outputs the same.

Am I missing something?

@jakegiltsoff
Copy link
Owner

@mitchrenton Is that with the default fonts? If you alter the cap-height values in the variables they will be different.

@paulhbarker
Copy link

I'm having the same problem. I've switched out the defaults with my own and modified their cap-heights as well, but the mixin doesn't respect font type.

@jakegiltsoff
Copy link
Owner

@paulhbarker hmm, it does use the font’s defined cap-height in the equations so there may be a different issue causing what you are seeing. It could be an issue there seems to be with the minified css not updating every time causing it to look like this is happening?

@paulhbarker
Copy link

paulhbarker commented Jul 16, 2016

I took a look at it today and you're right, it does use the cap-height of the specified font, but the documentation (your blog post) led me to believe that it would actually set the font-family property, when it only uses the font argument to calculate the padding/margins/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants