Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple identity store to get started #289

Open
arjantijms opened this issue May 15, 2023 · 6 comments
Open

Add simple identity store to get started #289

arjantijms opened this issue May 15, 2023 · 6 comments
Assignees
Labels
Milestone

Comments

@arjantijms
Copy link
Contributor

The currently provided identity stores for LDAP and JDBC require some effort to populate.

Especially for people new to the platform, and even more so for example code, something simpler is required.

The biggest challenge is not in defining something simpler, but in getting it through the process. In the past there's always that one person who thinks it's insecure to have a simple store, and subsequently the proposal is withdrawn again.

@m-reza-rahman
Copy link

I've always tried to support this. I suggest committers vote on a formal proposal using the normal consensus process.

@hantsy
Copy link

hantsy commented May 25, 2023

I remember the original version had an In Memory implementation, but not included in the final version.

@arjantijms
Copy link
Contributor Author

I remember the original version had an In Memory implementation, but not included in the final version.

Indeed. It's still in Soteria, but someone raised a concern that it may not be secure, so it was left out of the spec.

See; https://github.com/eclipse-ee4j/soteria/blob/master/impl/src/main/java/org/glassfish/soteria/identitystores/EmbeddedIdentityStore.java

@hantsy
Copy link

hantsy commented May 27, 2023

It is good for demonstration and writing tests purpose.

Spring Security also provides in-memory Map based UserDetialsService,eg https://github.com/spring-projects/spring-security/blob/main/core/src/main/java/org/springframework/security/core/userdetails/MapReactiveUserDetailsService.java.

But Embedded here confuse a little for me with JPA @Embeddalbe and @EmbeddedId.

@arjantijms
Copy link
Contributor Author

But Embedded here confuse a little for me with JPA @Embeddalbe and @EmbeddedId.

InMemmory would be fine too. I can rename it to that for the M1 release.

M1 is meant for feedback and to show progress. Nothing in it necessarily has to be like that in the final version, so we can allow ourselves some freedom.

arjantijms added a commit to arjantijms/security that referenced this issue Dec 4, 2023
This store is mostly intended for test purposes and to get started

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms
Copy link
Contributor Author

@hantsy @m-reza-rahman see #304

@arjantijms arjantijms self-assigned this Dec 4, 2023
@arjantijms arjantijms added this to the 4.0 milestone Dec 4, 2023
@arjantijms arjantijms added the M1 label Dec 4, 2023
arjantijms added a commit that referenced this issue Dec 4, 2023
Provide a simple in-memory identity store as per #289
@arjantijms arjantijms added the 4.0 label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants