Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API uses outdated bundle packaging #1174

Open
JanWesterkamp-iJUG opened this issue Aug 22, 2023 · 1 comment
Open

API uses outdated bundle packaging #1174

JanWesterkamp-iJUG opened this issue Aug 22, 2023 · 1 comment

Comments

@JanWesterkamp-iJUG
Copy link

JanWesterkamp-iJUG commented Aug 22, 2023

The Jakarta REST(ful Web Service) API artifact uses an outdated packaging type bundle, which creates several issues. This should be jar (Maven default) instead.

The maven-bundle-plugin configuration may need a refactoring then:

rest/jaxrs-api/pom.xml

Lines 122 to 154 in 57216fe

<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>${maven.bundle.plugin.version}</version>
<extensions>true</extensions>
<configuration>
<instructions>
<_failok>true</_failok>
<Build-Id>${buildNumber}</Build-Id>
<Bundle-Description>Jakarta RESTful Web Services API (JAX-RS)</Bundle-Description>
<Bundle-Version>${project.version}</Bundle-Version>
<Bundle-SymbolicName>jakarta.ws.rs-api</Bundle-SymbolicName>
<DynamicImport-Package>*</DynamicImport-Package>
<Extension-Name>${api.package}</Extension-Name>
<Implementation-Version>${project.version}</Implementation-Version>
<Specification-Version>${spec.version}</Specification-Version>
<Specification-Vendor>Eclipse Foundation</Specification-Vendor>
<specversion>${spec.version}</specversion>
<_versionpolicy>[$(version;==;$(@)),$(version;+;$(@)))</_versionpolicy>
<_nodefaultversion>false</_nodefaultversion>
<Require-Capability>osgi.ee;filter:="(&amp;(osgi.ee=JavaSE)(version=1.8))"</Require-Capability>
</instructions>
</configuration>
<executions>
<execution>
<id>osgi-bundle</id>
<phase>package</phase>
<goals>
<goal>bundle</goal>
</goals>
</execution>
</executions>
</plugin>

Latest plugin version: 5.1.9

Doc:

I can create a PR, which then need a review (from an OSGi expert at best).

@mkarg
Copy link
Contributor

mkarg commented Aug 23, 2023

Can you please refer to the actual problems we need to resolve, just for better understanding why we should touch this? Thanks.

Feel free to post a PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants