-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate unused composite:extension #1549
Comments
Thanks @tandraschko |
Email for reference: https://www.eclipse.org/lists/faces-dev/msg00070.html |
Remove without deprecation? Edit: something like this thus? eclipse-ee4j/mojarra@08e737d |
Remove unused composite:extension
for me it would also be ok to deprecate first in 4.1 |
Although this is unused, this could still be considered a breaking change? If we deprecate it in 4.1, should it stay deprecated in 5.0 until it can be removed in the next major release after 5.0? |
I'll try to have this brought up in one of the upcoming Jakarta Platform calls to get approval to have this removed without deprecation. I don't know too much about this tag or it's history, however. Looking around a bit though... The VLD Doc says: As Arjan said in the email thread, JSR 276 Link: https://download.oracle.com/otn-pub/jcp/dt_metadata_jsf-0.5-edr-oth-JSpec/dt_metadata-jsf-0_5-edr-spec.pdf?AuthParam=1694566997_26177af8a0e9d6b66f87b4d5b0192d95 which also mentions: MyFaces did not implement anything as Thomas said. We just have a TODO note:
So I guess this tag wasn't really followed up with. So in terms of behavior, it should be okay to remove it? Only issue is if a facelet does use the tag (for whatever reason -- i.e demo apps), then it should remove it to avoid undefined tag errors. |
Discussed at 2023-09-19 Platform Project meeting:
|
I think it was a misunderstanding. Approval was to remove them from 5.0 (since faces 5.0 is part of EE11, but meeting minutes don't state it explicitly) Spec Committee Minutes from Sept 20 2023:
|
Ah okay. I'll look how best to deprecate the composite:extension. |
Sounds good. I was thinking of just adding a warning if it was used? Edit: just saw your PR. Javadoc is be good too. I see what I can do in myfaces, too. |
fixed in myfaces via @BalusC safe to close this issue? |
as discussed on the mailing list
The text was updated successfully, but these errors were encountered: