Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of spec-version-maven-plugin #380

Open
KyleAure opened this issue Nov 16, 2023 · 0 comments
Open

Purpose of spec-version-maven-plugin #380

KyleAure opened this issue Nov 16, 2023 · 0 comments
Assignees
Labels
build CI/CD pipelines related tasks.

Comments

@KyleAure
Copy link
Contributor

KyleAure commented Nov 16, 2023

The API build depends on this plugin:

concurrency/api/pom.xml

Lines 74 to 94 in d24bd40

<!-- First sets properties for the maven-bundle-plugin and later checks if they are indeed used. -->
<plugin>
<groupId>org.glassfish.build</groupId>
<artifactId>spec-version-maven-plugin</artifactId>
<version>2.1</version>
<configuration>
<spec>
<specVersion>3.1</specVersion>
<specImplVersion>${project.version}</specImplVersion>
<apiPackage>jakarta.enterprise.concurrent</apiPackage>
</spec>
</configuration>
<executions>
<execution>
<goals>
<goal>set-spec-properties</goal>
<goal>check-module</goal>
</goals>
</execution>
</executions>
</plugin>

Which currently fails our release build when attempting to create a release with the tag 3.1.0-M1
Due to this known issue: eclipse-ee4j/glassfish-spec-version-maven-plugin#14

[INFO] --- spec-version:2.1:check-module (default) @ jakarta.enterprise.concurrent-api ---

[ jakarta.enterprise.concurrent:jakarta.enterprise.concurrent-api:3.1.0-M1 ]
{ groupIdPrefix=jakarta. spec-version=3.1 apiPackage=jakarta.enterprise.concurrent API final spec-impl-version=3.1.0-M1 }
- WARNING: Bundle-Version (3.1.0.M1) should be 3.1.0-M1

What exactly is the purpose of this plugin and is it necessary?
I can work around it for this release, but long term it might be a problem.

@KyleAure KyleAure added certification Compatibility certification request build CI/CD pipelines related tasks. labels Nov 16, 2023
@KyleAure KyleAure self-assigned this Nov 16, 2023
@KyleAure KyleAure removed the certification Compatibility certification request label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI/CD pipelines related tasks.
Projects
None yet
Development

No branches or pull requests

1 participant