Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job spec files are not picking up revremark #795

Closed
starksm64 opened this issue Mar 7, 2024 · 1 comment
Closed

CI job spec files are not picking up revremark #795

starksm64 opened this issue Mar 7, 2024 · 1 comment
Assignees

Comments

@starksm64
Copy link
Contributor

Describe the bug
The jakarta-cdi-spec-4.1.html and jakarta-cdi-spec-4.1.pdf attached to the CDI Release-JDK17 job build artifacts are showing the correct date, but have the revremark from the pom.xml:

4.1, March 07, 2024: Draft(M1)

The job shows that the revremark was override on the command line with -Drevremark=Final.

Expected behavior
The document revremark should be using the override value passed in on the command line from the build job parameters. When I use the same command line on a local build of the 4.1.0 tagged branch I see the spec files with the revremark from the command line.

Additional context
Add any other context about the problem here.

@starksm64 starksm64 self-assigned this Mar 7, 2024
@starksm64
Copy link
Contributor Author

It seems the release:prepare phase modifies only the versions of the pom files and then creates a separate script to run the release on these. The simplest solution for now is to simply run the build of the spec subproject again after the release build with the license and revremark properties specified. I tried a 5.0.0.Alpha1 build on main with the spec marked as final and that worked. That build has been dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant