Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a beans_4_1.xsd descriptor #792

Closed
starksm64 opened this issue Mar 6, 2024 · 3 comments · Fixed by #793
Closed

Add a beans_4_1.xsd descriptor #792

starksm64 opened this issue Mar 6, 2024 · 3 comments · Fixed by #793
Milestone

Comments

@starksm64
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Apparently there is now a requirement to provide a new deployment descriptor for the major/minor updates even if there is no change in content.

Describe the solution you'd like
Copy the beans_4_0.xsd to beans_4_1.xsd and change 4.0 to 4.1. The spec also needs to be updated.

@starksm64
Copy link
Contributor Author

@manovotn Does this break anything in Weld if a deployment descriptor uses a 4.1 version such as:

<beans xmlns="https://jakarta.ee/xml/ns/jakartaee"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee
         https://jakarta.ee/xml/ns/jakartaee/beans_4_1.xsd"
         version="4.1">
            ...
         </beans>

?

starksm64 added a commit to jakartaredhat/cdi that referenced this issue Mar 6, 2024
fixes jakartaee#792

Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64
Copy link
Contributor Author

I tried a basic test in the current Weld main branch and don't see any problem. I also don't see anywhere the version dictates any behavior.

@manovotn
Copy link
Contributor

manovotn commented Mar 7, 2024

@manovotn Does this break anything in Weld if a deployment descriptor uses a 4.1 version such as:

<beans xmlns="https://jakarta.ee/xml/ns/jakartaee"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee
         https://jakarta.ee/xml/ns/jakartaee/beans_4_1.xsd"
         version="4.1">
            ...
         </beans>

?

No, shouldn't make a difference.

starksm64 added a commit that referenced this issue Mar 7, 2024
…jar. (#793)

* Add a beans_4_1.xsd schema file
fixes #792
* Revert the dev version back to 4.1.0-SNAPSHOT to replace the current 4.1.0 staged api jar to pickup the beans_4_1.xsd schema file.

---------

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants