Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this package work? #48

Open
Zyles opened this issue Jun 1, 2017 · 3 comments
Open

Does this package work? #48

Zyles opened this issue Jun 1, 2017 · 3 comments

Comments

@Zyles
Copy link

Zyles commented Jun 1, 2017

I get no output, no errors, no way to debug.

Nothing.

@popey456963
Copy link

Works for me. Post code and file you're running it on?

Plus OS, Node version, etc.

@Zyles
Copy link
Author

Zyles commented Jul 8, 2017

I think the issue was my file is UTF-16. You should check if you can support that or custom encodings.

I changed lib now however so I can not test further.

Win 10 and latest nodejs.

@popey456963
Copy link

popey456963 commented Jul 9, 2017

@Zyles For me, the following worked with a UTF-16 encoded file:

byline(fs.createReadStream('test.txt', { encoding: 'utf16' }))

Did you remember to change the encoding in your read stream? Encoding isn't really handled by this module, it gets a raw read stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants