Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computeConnectionPoint doesn't respect links_render_mode #457

Open
chrisgoringe opened this issue Mar 13, 2024 · 0 comments
Open

computeConnectionPoint doesn't respect links_render_mode #457

chrisgoringe opened this issue Mar 13, 2024 · 0 comments

Comments

@chrisgoringe
Copy link

At litegraph.js:9767 it says computeConnectionPoint returns the link center point:

   //returns the link center point based on curvature
    LGraphCanvas.prototype.computeConnectionPoint = function(

But in fact the function takes a value t to specify distance along the link. It then assumes a LiteGraph.SPLINE_LINK in calculating the path. This is correct for all paths if t=0.5 (the original usage, I assume, from the comment) but incorrect for other values of links_render_mode.

As a result any use of the flow animation is broken for links_render_mode != LiteGraph.SPLINE_LINK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant