New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint and/or prettier run #429
Comments
Hi Jack: I always had my own styling but it was pretty flexible. But some years ago one user did a PR with a full linting of the code and I accepted it because I thought it could make it more coherent, but the truth is that the ruleset applied made the code way less readable so I decided to reformat it manually in some parts, I guess thats the problem with the current ruleset. But feel free to lint it and do a PR, Im always willing to check it, I lack the experience you have probably. |
In the JS-world of things,
From a quick skim of the issues, I think this may have been where the 'undesired style changes' were previously mentioned:
Related: |
I am running into some issues with inconsistent styling and would like to request that the recommended eslint / prettier formatting is done on the whole project. I don't really have a preference as to which format / style is used and I leave that up to the maintainer. I can change my workflow to accommodate any consistent style. I don't want to step on any toes but it makes sense to me to have the whole project saved in the same styling, whatever that styling may be.
Since I don't know what your editor's rules are, I'd like to request that the js files get a 'Format Document' or 'Format Document With' and one of the suggested vs code extension implementations run on them.
If there's some specific styling preference that parts of the code are formatted in one way and other parts are formatted in a specific but different way, then it's fine and you can close this issue.
Personally, it's a lot of mental overhead to manually align the mixed use of only tabs, only spaces and tabs and spaces since I rely on formatting for readability, ease of development and staying in flow.
Again, if it's some specific reasoning and it's just a hassle to deal with this, feel free to close this issue.
<3
The text was updated successfully, but these errors were encountered: