Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes in upgrading OTEL Collector #5302

Closed
yurishkuro opened this issue Mar 26, 2024 · 2 comments · Fixed by #5314
Closed

Fix breaking changes in upgrading OTEL Collector #5302

yurishkuro opened this issue Mar 26, 2024 · 2 comments · Fixed by #5314
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

PR #5301. Looks like breaking changes in the collector.

One of the errors: Error: ../../../go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zipkinreceiver@v0.96.0/trace_receiver.go:61:25: undefined: component.ErrNilNextConsumer

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Mar 26, 2024
@Mona3087
Copy link

I am interested to pick this up

@lekaf974
Copy link
Contributor

There was a braking change in this PR open-telemetry/opentelemetry-collector#9322 which looks to be fix by this one open-telemetry/opentelemetry-collector-contrib#31793

should be fix by upgrading opentelemetry-collector-contrib to v0.97.0

yurishkuro pushed a commit that referenced this issue Apr 2, 2024
## Which problem is this PR solving?
- Fix #5302 

## Description of the changes
- 

## How was this change tested?
- 

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: mevrin <matthieu.evrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants