Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltip Arrow Configuration in Ant Design Components #2221

Open
bupd opened this issue Mar 20, 2024 · 1 comment · May be fixed by #2222
Open

Update Tooltip Arrow Configuration in Ant Design Components #2221

bupd opened this issue Mar 20, 2024 · 1 comment · May be fixed by #2222
Labels

Comments

@bupd
Copy link
Contributor

bupd commented Mar 20, 2024

What happened?

arrowPointatCenter

The Arrow Point at center for the tooltip has been officially deprecated in Antd. Since we are using antd v5.
We should stop using the arrow pointAtCenter and move to arrow: {{ pointAtCenter: true }}

We need to remove the old convention and move to the updated convention to avoid future issues.

Steps to reproduce

  1. With the deprecation of the arrowPointAtCenter as boolean property in Ant Design Tooltip component, it's crucial to update our codebase to adhere to the latest conventions provided by Ant Design version 5.

Expected behavior

To align with the latest Ant Design conventions and avoid future compatibility issues, we need to update our codebase to use the arrow property with pointAtCenter: true configuration instead of arrowPointAtCenter.

By updating the Tooltip arrow configuration to use the latest Ant Design conventions, we ensure compatibility with future versions of Ant Design and avoid potential deprecation warnings. This proactive approach helps maintain the stability and longevity of our codebase, contributing to better maintainability and scalability of our application.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@bupd bupd added the bug label Mar 20, 2024
@bupd
Copy link
Contributor Author

bupd commented Mar 20, 2024

Here are the Steps I am going to implement for solving this issue.

  1. Identify all occurrences of arrowPointAtCenter property usage in our codebase.
  2. Replace each instance with the updated arrow property with pointAtCenter: true configuration.
  3. Test the updated components to ensure they function as expected with the new configuration.

@bupd bupd linked a pull request Mar 20, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant