Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Archive button is enabled by default #2201

Open
ViliusS opened this issue Mar 8, 2024 · 2 comments
Open

[Bug]: Archive button is enabled by default #2201

ViliusS opened this issue Mar 8, 2024 · 2 comments
Labels

Comments

@ViliusS
Copy link

ViliusS commented Mar 8, 2024

What happened?

Not sure if this a bug in the UI or in the Jaeger itself, but we have upgraded our Jaeger instances controlled with Jaeger Operator from 1.51 to 1.54. This updated UI from 1.35 to 1.38. Now on at least all-in-one configuration Archive button is enabled by default.

Steps to reproduce

  1. Install Jaeger Operator 1.54
  2. Use this simple YAML to deploy the instance:
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger
  namespace: default
spec:
  strategy: allInOne
  allInOne:
    options:
      query:
        base-path: /
  ingress:
    ingressClassName: nginx
    hosts:
      - yourhost.example.com
    pathType: Prefix
  storage:
    options:
      memory:
        max-traces: 100000

Expected behavior

Archive button should be disabled by default, as per documentation.

Relevant log output

No response

Screenshot

No response

Additional context

It is probably due changes in #1944.

Jaeger backend version

1.54

SDK

No response

Pipeline

No response

Stogage backend

memory

Operating system

No response

Deployment model

Jaeger Operator for Kubernetes

Deployment configs

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger
  namespace: default
spec:
  strategy: allInOne
  allInOne:
    options:
      query:
        base-path: /
  ingress:
    ingressClassName: nginx
    hosts:
      - yourhost.example.com
    pathType: Prefix
  storage:
    options:
      memory:
        max-traces: 100000
@ViliusS ViliusS added the bug label Mar 8, 2024
@yurishkuro
Copy link
Member

why is it a problem? The button now reacts to the capability of the underlying backend, if archive is available (as it is with Memory store) then the button shows. I believe there is a UI flag to turn if off.

@ViliusS
Copy link
Author

ViliusS commented Mar 12, 2024

I don't think that that turning on archive button for in-memory backend is correct. The idea that trace can be archived implies that it will be stored permanently. For in-memory backend archived traces won't be persistent between Jaeger restarts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants