Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Limit span logs by the select time range (zoom) #2002

Open
SOF3 opened this issue Nov 24, 2023 · 4 comments
Open

[Feature]: Limit span logs by the select time range (zoom) #2002

SOF3 opened this issue Nov 24, 2023 · 4 comments

Comments

@SOF3
Copy link
Contributor

SOF3 commented Nov 24, 2023

Requirement

I often have large spans with a lot (hundreds or thousands) of logs over a wide time range. I want to limit log lists to the dynamically selected time range so that I can quickly view log details without scrolling a lot or searching a smaller trace.

Problem

While I can identify the events I want by hovering over the event ticks on the span, I cannot view the fields of the logs from the hover (my logs often sometimes have large JSON documents). I need to expand the logs below, which means I have to locate the timestamp and binary search the corresponding log entry again.

Proposal

When I zoom in to a smaller time range, the logs beyond the time range should be hidden from the logs list to reduce noise. Currently the table caption is Logs (N). We could change it to:

Logs (m of N) (show more) (show all)

Open questions

No response

@yurishkuro yurishkuro changed the title [Feature]: Logs should only display [Feature]: Limit span logs by the select time range (zoom) Nov 24, 2023
@khareyash05
Copy link

khareyash05 commented Nov 26, 2023

Hey! I would like to contribute on this issue! I am new to this project. Could you please let me know where can I access the logs? Is it the traces on the home you are talking about? @SOF3
Thank you

@yurishkuro
Copy link
Member

@khareyash05 the logs appear as vertical ticks in the trace view. A sample trace with logs can be produced via the HotROD demo app.

@SOF3
Copy link
Contributor Author

SOF3 commented Nov 27, 2023

Example from https://kubewharf.io/kelemetry/trace-deployment:
image
I only selected 2.23s..4.5s, so the last three logs should not be displayed

@SOF3
Copy link
Contributor Author

SOF3 commented Nov 27, 2023

@yurishkuro "Collapse" doesn't sound exactly relevant here. GitHub collapses diffs because git diffs have multiple disjoint intervals of lines, while Jaeger only shows a single continuous interval at a time, so there are no "holes" to collapse. Maybe a toggle to show/hide out-of-range logs would be sufficient (although personally I think it's good enough to just indicate e.g. "n more logs before|after selected range" using the AccordianLogs--foter class).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants