Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Duration of overlapping operations is calculating incorrectly in TraceGraph view #1918

Open
maxgaponov opened this issue Oct 30, 2023 · 1 comment · May be fixed by #1920
Open

[Bug]: Duration of overlapping operations is calculating incorrectly in TraceGraph view #1918

maxgaponov opened this issue Oct 30, 2023 · 1 comment · May be fixed by #1920
Labels

Comments

@maxgaponov
Copy link
Contributor

What happened?

Currently the duration of an operation in Trace Graph view is calculating as a sum of the invocations of this operation. It works incorrectly in the case of overlapping spans and leads to the situation where the duration of a child can be greater than the duration of its parent. My proposal is to calculate the duration of the union of the spans like we do for child nodes.

Steps to reproduce

  1. Open example_trace.json in Jaeger UI
  2. Navigate to Trace Graph view

Expected behavior

Expected that the duration of a node is not greater than the duration of its parent.
The total duration for overlapping spans should be the duration of their union, but not the sum.

Relevant log output

No response

Screenshot

image

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@maxgaponov maxgaponov added the bug label Oct 30, 2023
maxgaponov added a commit to maxgaponov/jaeger-ui that referenced this issue Oct 30, 2023
Resolves jaegertracing#1918
Now the total duration is calculating as
the duration of the union of spans.

Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
@maxgaponov maxgaponov linked a pull request Oct 30, 2023 that will close this issue
4 tasks
@maxgaponov
Copy link
Contributor Author

After fix
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant