Remove dependency on enzyme #1668

yurishkuro · 2023-08-12T23:03:35Z

Enzyme is not compatible with React 18, so we need to phase it out.

Preferred approach is to migrate to react-testing-library. In some cases we may use a replacement shallow function #1653, but only when absolutely necessary, it's better to move away from snapshot testing.

For examples of this being partially done, see merged PRs in this ticket below (e.g. #1659 #1653 #1643).

The scope of this is sizeable, so the recommendation is to limit the changes to specific modules, a couple test files at a time.

Current enzyme references (Nov 9):

$ grep -rn enzyme packages/jaeger-ui/src
packages/jaeger-ui/src/utils/redux-form-field-adapter.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/Monitor/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/Monitor/EmptyState/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/Monitor/ServicesView/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/Monitor/ServicesView/serviceGraph.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.test.js:16:import { mount, shallow } from 'enzyme';
packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/opsGraph.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/QualityMetrics/MetricCard.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/QualityMetrics/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/QualityMetrics/Header.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/SearchableSelect.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/CircularProgressbar.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/TraceName.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/EmphasizedNode.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/DetailsCard/DetailList.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/DetailsCard/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/DetailsCard/DetailTable.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/DetailsCard/DetailTableDropdown.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/UiFindInput.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/ExternalLinks.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/ErrorMessage.test.js:16:import { shallow, mount } from 'enzyme';
packages/jaeger-ui/src/components/common/FilteredList/highlightMatches.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/FilteredList/ListItem.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/FilteredList/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/VerticalResizer.test.js:16:import { mount } from 'enzyme';
packages/jaeger-ui/src/components/common/ExamplesLink.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/CopyIcon.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/common/NameSelector.test.js:18:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/SidePanel/DetailsPanel.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/SidePanel/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/index.test.js:24:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Graph/getNodeRenderers.test.js:15:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Graph/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/traces.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Header/ChevronDown.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Header/LayoutSettings/index.test.js:17:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Header/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/Selector.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/renderNode.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceHeader.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceDiffHeader.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceIdInput.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/CohortTable.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/CohortTable.test.js:62:   * when props change because enzyme does not support wrapper.setProps for classes that render an array of
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/CohortTable.test.js:155:      // traceNameRenderer returns a React Fragment, wrapper div helps enzyme
packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/CohortTable.test.js:178:      // traceNameRenderer returns a React Fragment, wrapper div helps enzyme
packages/jaeger-ui/src/components/TraceDiff/TraceDiff.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DependencyGraph/DependencyForceGraph.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DependencyGraph/ForceGraphArrowLink.test.js:22:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/DependencyGraph/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceSpanView/index.test.js:16:import { mount, shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/url/ReferenceLink.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/index.test.js:32:import { shallow, mount } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/KeyboardShortcutsHelp.test.js:17:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/AltViewOptions.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.test.js:16:import { shallow, mount } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/CanvasSpanGraph.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/TickLabels.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/ViewingLayer.test.js:15:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/Scrubber.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/GraphTicks.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceFlamegraph/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceGraph/TraceGraph.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceGraph/OpNode.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/ArchiveNotifier/index.test.js:16:import { mount, shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.test.js:16:import { mount, shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.test.js:15:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/ReferencesButton.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/ListView/index.test.js:16:import { mount, shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/AccordianKeyValues.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/TextList.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.test.js:19:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/AccordianText.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/AccordianLogs.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/AccordianReferences.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/KeyValuesTable.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.test.js:15:import { shallow, mount } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/Ticks.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/TimelineHeaderRow/TimelineViewingLayer.test.js:16:import { mount } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/TimelineHeaderRow/TimelineCollapser.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/TimelineHeaderRow/TimelineHeaderRow.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceStatistics/index.test.js:16:import { mount } from 'enzyme';
packages/jaeger-ui/src/components/TracePage/TraceStatistics/PopupSql.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/DiffSelection.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/AltViewOptions.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/DownloadResults.test.js:17:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js:17:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ScatterPlot.test.js:16:import { mount, shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItemTitle.test.js:17:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/FileLoader.test.js:16:import { shallow } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/index.test.js:32:import { mount } from 'enzyme';
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js:19:import { shallow } from 'enzyme';

The text was updated successfully, but these errors were encountered:

Sangam-ghimire · 2023-08-13T06:05:22Z

I want to work on this @yurishkuro. Can you assign it to me please? Will be a very good start for me

yurishkuro · 2023-08-13T06:29:17Z

We do not assign issues. There are multiple packages that are affected, don't try to change all in one PR.

Sangam-ghimire · 2023-08-13T06:36:56Z

@yurishkuro Any previous discussion that I should not miss, execpt the mentioned ones.

AbhishekTiwari23 · 2023-08-13T07:41:00Z

I also want to work on this. There are several test files, so I think we can split the task between us, @Sangam-ghimire. Please let me know if you want to handle all the files alone because if we both work on same files, it will waste time for both of us.
Thanks

Sangam-ghimire · 2023-08-13T07:44:16Z

Sure @AbhishekTiwari23 that's a great spirit. Let's split and work together. I might need some help too.

anshgoyalevil · 2023-08-13T09:01:06Z

@Sangam-ghimire @AbhishekTiwari23 Please have a look at the discussion among the PRs: #1659 #1653 #1643
It would help you understand the issue's landscape.

anikdhabal · 2023-08-13T09:56:01Z

https://testing-library.com/docs/react-testing-library/migrate-from-enzyme
https://medium.com/zipyai/migrating-from-enzyme-to-react-testing-library-b1fb607d81ab
you can refer these @Sangam-ghimire @AbhishekTiwari23

AbhishekTiwari23 · 2023-08-14T15:06:50Z

Thanks, working on it

## Which problem is this PR solving? - part of #1668 - migrating the existing Enzyme based tests to React Testing Libary ## Description of the changes Currently I migrated 3 files - `QualityMetrics/BannerText.test.js` - `QualityMetrics/CountCard.test.js` ## How was this change tested? - replaced the shallow module from enzyme to render from RTL ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Freedisch <freeproduc@gmail.com> Signed-off-by: Freedisch <freeproduc@gamil.com> Co-authored-by: Freedisch <freeproduc@gamil.com>

## Which problem is this PR solving? - This PR migrates the `TraceIDSearchInput.test.js` from Enzyme to RTL - Snapshot testing is replaced with specific expect statement - Part of: #1668 ## How was this change tested? - Using yarn lint && yarn test-ci TraceIDSearchInput --coverage ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>

## Which problem is this PR solving? - This PR migrates the `DAG.test.js` from Enzyme to RTL - part of: #1668 ## How was this change tested? - Using `yarn test-ci` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>

## Which problem is this PR solving? - This PR Migrates `SpanBar.test.js` from Enzyme to RTL - part of: #1668 ## How was this change tested? - using `yarn test-ci` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>

## Which problem is this PR solving? - This PR migrates the test `NewWindowIcon.test.js` from Enzyme to RTL - part of: #1668 ## How was this change tested? - using `yarn test-ci` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>

anikdhabal · 2023-08-27T13:55:44Z

Thanks, working on it

Have you started?

suhail34 · 2023-09-12T09:21:38Z

I am working over here https://github.com/jaegertracing/jaeger-ui/tree/main/packages/jaeger-ui/src/components/App is that fine

suhail34 · 2023-09-16T10:00:30Z

Now i am thinking to work on components/DeepDependencies

## Which problem is this PR solving? - Part of #1668 - Using React Testing Library to remove dependency on enzyme for index.test.js and TopNav.test.js ## How was this change tested? - Tested my changes inside packages/jaeger-ui/ using command `npx jest --testPathPattern=src/components/App/.*\.test\.js` - Also performed yarn test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: suhail34 <suhailkna@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us>

## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes Migrated the `TraceTimelineLink.test.js` to `RTL` using the idiomatic RTL practices ## How was this change tested? Ran the test suite to ensure all changes passed. ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us>

## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes Migrated one component to RTL ## How was this change tested? Ran the test suite and ensured all of them pass ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>

EshaanAgg · 2023-11-10T04:01:51Z

Hi! I have been migrating some files to RTL, and one common pattern that I keep stumbling upon is using snapshots in testing. Have any tests been migrated from enzyme to RTL containing snapshots, or should I research the same and propose a way forward?

The reason I'm saying this is due to the bulky snapshots generated by RTL and the fact that it is built to test for user interactions, and not necessarily the rendered DOM.

cc: @anshgoyalevil @yurishkuro

yurishkuro · 2023-11-10T04:07:26Z

@EshaanAgg in many cases snapshot testing is just lazy tests. Ideally we want to move away from those to more explicit tests like the two you fixed today. But we do have a shortcut that still allows to use snapshots without enzyme, as in #1653.

## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes Migrates the test for `ChevronDown.tsx` to RTL ## How was this change tested? Ran the test suite locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>

EshaanAgg · 2023-11-10T04:11:04Z

Ahh, I got it. I'll try to experiment with the tests and see if we can move away from them in some components.

## Which problem is this PR solving? Fixes part of jaegertracing#1668 ## Description of the changes Migrates the test for `ChevronDown.tsx` to RTL ## How was this change tested? Ran the test suite locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>

## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes Migrates `TraceHeader.tsx` from enzyme to RTL. Removes the snapshot tests to relevant assertions with the help of `test-ids`. ## How was this change tested? Running the test suite locally. ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

…zyme to RTL (#2066) ## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes - Migrates `ExamplesLink` and `EmphasizedNode` components from enzyme to RTL - Replaces snapshot testing with actual test for the URLs ## How was this change tested? Running the tests locally ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>

## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes Migrate `ExternalLinks` component from enzyme to RTL ## How was this change tested? Ran the tests locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>

## Which problem is this PR solving? Fixes part of #1668 ## Description of the changes Migrates the following components from Enzyme to RTL 1. `CircularProgressbar` 2. `ErrorMessage` 3. `TraceName` - Removed the instances of snapshot testing from the same and migrated to tests checking the functionality associated with them - Refactored some of the original code of the components to make them more readable ## How was this change tested? - Running the tests locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>

This was referenced Mar 12, 2023

Help needed with upgrading dependencies #1199

Open

Migrate ScoreCard.test.js from Enzyme to React Shallow Renderer #1653

Merged

yurishkuro added help wanted good first issue labels Aug 12, 2023

Freedisch mentioned this issue Aug 15, 2023

[tests] Remove enzyme from QualityMetrics tests #1684

Merged

3 tasks

anshgoyalevil mentioned this issue Aug 16, 2023

[tests] Migrate TraceIDSearchInput.test from Enzyme to RTL #1691

Merged

4 tasks

anshgoyalevil mentioned this issue Aug 17, 2023

[test] Migrate DAG.test.js from Enzyme to RTL #1694

Merged

4 tasks

anshgoyalevil mentioned this issue Aug 18, 2023

[test] Migrate SpanBar.test.js from Enzyme to RTL #1695

Merged

4 tasks

anshgoyalevil mentioned this issue Aug 19, 2023

[test] Migrate NewWindowIcon.test.js from Enzyme to RTL #1701

Merged

4 tasks

suhail34 mentioned this issue Sep 15, 2023

Remove dependency on enzyme from components/App #1795

Merged

4 tasks

This was referenced Nov 9, 2023

refac: migrate ReferenceLink.test.js from enzyme to RTL #1959

Merged

Migrate TraceTimelineLink.test.js from enzyme to RTL #1960

Merged

EshaanAgg mentioned this issue Nov 10, 2023

refac: migrate ChevronDown from enzyme to RTL #1961

Merged

4 tasks

EshaanAgg mentioned this issue Nov 10, 2023

Migrate TraceDiffs/Header from enzyme to RTL #1962

Merged

4 tasks

EshaanAgg mentioned this issue Nov 13, 2023

refac: Migrate CopyIcon component from enzyme to RTL #1973

Closed

4 tasks

This was referenced Dec 24, 2023

migrate: Migrate ExternalLinks component from enzyme to RTL #2065

Merged

refac: migrate ExamplesLink and EmphasizedNode components from enzyme to RTL #2066

Merged

EshaanAgg mentioned this issue Dec 25, 2023

Refac: Migrate 3 components from Enzyme to RTL #2070

Merged

4 tasks

EshaanAgg mentioned this issue Jan 27, 2024

Migrate to Vue Testing Library learningequality/kolibri-design-system#510

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependency on enzyme #1668

Remove dependency on enzyme #1668

yurishkuro commented Aug 12, 2023 •

edited

Sangam-ghimire commented Aug 13, 2023

yurishkuro commented Aug 13, 2023

Sangam-ghimire commented Aug 13, 2023

AbhishekTiwari23 commented Aug 13, 2023

Sangam-ghimire commented Aug 13, 2023

anshgoyalevil commented Aug 13, 2023

anikdhabal commented Aug 13, 2023 •

edited

AbhishekTiwari23 commented Aug 14, 2023

anikdhabal commented Aug 27, 2023 •

edited

suhail34 commented Sep 12, 2023

suhail34 commented Sep 16, 2023

EshaanAgg commented Nov 10, 2023 •

edited

yurishkuro commented Nov 10, 2023 •

edited

EshaanAgg commented Nov 10, 2023 •

edited

Remove dependency on enzyme #1668

Remove dependency on enzyme #1668

Comments

yurishkuro commented Aug 12, 2023 • edited

Sangam-ghimire commented Aug 13, 2023

yurishkuro commented Aug 13, 2023

Sangam-ghimire commented Aug 13, 2023

AbhishekTiwari23 commented Aug 13, 2023

Sangam-ghimire commented Aug 13, 2023

anshgoyalevil commented Aug 13, 2023

anikdhabal commented Aug 13, 2023 • edited

AbhishekTiwari23 commented Aug 14, 2023

anikdhabal commented Aug 27, 2023 • edited

suhail34 commented Sep 12, 2023

suhail34 commented Sep 16, 2023

EshaanAgg commented Nov 10, 2023 • edited

yurishkuro commented Nov 10, 2023 • edited

EshaanAgg commented Nov 10, 2023 • edited

yurishkuro commented Aug 12, 2023 •

edited

anikdhabal commented Aug 13, 2023 •

edited

anikdhabal commented Aug 27, 2023 •

edited

EshaanAgg commented Nov 10, 2023 •

edited

yurishkuro commented Nov 10, 2023 •

edited

EshaanAgg commented Nov 10, 2023 •

edited