Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: context root support for ingress #2240

Open
stanworld opened this issue Jun 15, 2023 · 6 comments
Open

[Feature]: context root support for ingress #2240

stanworld opened this issue Jun 15, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@stanworld
Copy link

Requirement

We have a domain name used for our applications in a cluster (mydomain.com), and would like to add jaeger support at mydomain.com/jaeger

Problem

When I try to create a ingress backed up jaeger-query service like:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: my-jaeger
spec:
ingressClassName: nginx
rules:

  • host: mydomain.com
    http:
    paths:
    • path: /jaeger
      pathType: Prefix
      backend:
      service:
      name: my-jaeger-jaeger-operator-jaeger-query
      port:
      number: 16686
      , the jaeger UI will have some js errors, indicating:

Refused to apply style from 'http://mydomain.com:9080/static/index-c3b54a40.css' because its MIME type ('text/plain') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
jaeger:41 GET http://mydomain.com:9080/static/index-5a1abd6a.js net::ERR_ABORTED 401 (Unauthorized)

Proposal

No response

Open questions

No response

@stanworld stanworld added the enhancement New feature or request label Jun 15, 2023
@stanworld
Copy link
Author

This is like a follow up for the host support at issue:

#135

@iblancasa
Copy link
Collaborator

Thanks for creating the issue. Would you like to send a PR? @stanworld

@stanworld
Copy link
Author

@iblancasa , I love to help but frankly I am quite new to this, and not sure where to get started. If someone can give some suggestions, I'd give a try.

@iblancasa
Copy link
Collaborator

@stanworld awesome!

  1. You will need to check what is missing in the Ingress object created by the operator
  2. Check pkg/ingress/query.go to see how Ingress objects are created
  3. Add an option to Jaeger.Spec.Query.Options similar to query.base-path for your missing fields. Or maybe, it can be a new field in Jaeger.Spec.Ingress.Options`.
  4. Add the missing stuff to the creation of the Ingress object
  5. Add an unit test
  6. Send your PR!

@iblancasa iblancasa assigned iblancasa and stanworld and unassigned iblancasa Jun 16, 2023
@stanworld
Copy link
Author

I think the issue is not within the ingress creation piece but how jaeger operator handles an ingress with a path. The template posted in the problem will actually create an ingress like mydomain.com/jaeger, but it seems js/css doesn't know how to handle it.

@stanworld stanworld removed their assignment Jun 20, 2023
@iblancasa
Copy link
Collaborator

@stanworld Is it a behavior you can reproduce without the operator? Because, in that case, it would make more sense to open an issue in the Jaeger repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants