Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the default IngressClass when no IngressClass is specified #2230

Closed
wants to merge 4 commits into from
Closed

Use the default IngressClass when no IngressClass is specified #2230

wants to merge 4 commits into from

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Get the default IngressClass and set it if no IngressClass was specified for the Jaeger instance

@iblancasa
Set default IngressClass to Jaeger Ingress if not IngressClass was pr…
3b01996 
…ovided jaegertracing#2225

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Fix unit test
b84699b 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@frzifus
Copy link
Member

frzifus commented Jun 14, 2023

same here, please update this branch or grant permission :)

@iblancasa
Merge branch 'main' of github.com:jaegertracing/jaeger-operator into …
91874ae 
…enhancement/2225
@iblancasa
Add missing permissions
6dca346 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@IshwarKanse
Copy link
Contributor

/test jaeger-e2e-tests

@frzifus
Copy link
Member

frzifus commented Jul 12, 2023

@IshwarKanse this branch is not up-to-date

@IshwarKanse
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

@iblancasa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4.13-hypershift-ci-index-jaeger-bundle 6dca346 link true /test ocp-4.13-hypershift-ci-index-jaeger-bundle
ci/prow/ocp-4.13-hypershift-images 6dca346 link true /test ocp-4.13-hypershift-images
ci/prow/jaeger-product-ocp-4.12-stage-images 6dca346 link true /test jaeger-product-ocp-4.12-stage-images
ci/prow/jaeger-product-ocp-4.13-stage-images 6dca346 link true /test jaeger-product-ocp-4.13-stage-images
ci/prow/jaeger-product-ocp-4.11-stage-images 6dca346 link true /test jaeger-product-ocp-4.11-stage-images
ci/prow/jaeger-product-ocp-4.14-stage-images 6dca346 link true /test jaeger-product-ocp-4.14-stage-images
ci/prow/jaeger-product-ocp-4.15-stage-images 6dca346 link true /test jaeger-product-ocp-4.15-stage-images
ci/prow/jaeger-product-ocp-4.14-arm-stage-images 6dca346 link true /test jaeger-product-ocp-4.14-arm-stage-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@parauliya
Copy link

/retest-required

@iblancasa iblancasa closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Ingress jaeger-query should use the default IngressClass if one is not provided
4 participants
@iblancasa @frzifus @IshwarKanse @parauliya