Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update helm-chart to use elasticsearch 8+ #532

Open
Stevenpc3 opened this issue Jan 4, 2024 · 7 comments
Open

[Feature]: Update helm-chart to use elasticsearch 8+ #532

Stevenpc3 opened this issue Jan 4, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Stevenpc3
Copy link
Contributor

Requirement

As a user of the helm-chart I would like the chart.yaml dependency of Elasticsearch to be updated to version 8+ so that I can use the latest or current versions of Elasticsearch with Jaeger.

Problem

Jeager was recently updated to support Elasticsearch version 8+ https://github.com/jaegertracing/jaeger/releases/tag/v1.52.0

But the chart still points to version 7.11.1 https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/Chart.yaml#L35

Blindly updating this likely will not work since the values.yaml settings are for the older verison and the index values have changed so things like "esIndexCleaner" and "esRollover" and "esLookback" will need to be updated to work with the new version.

Proposal

Someone tests the newer version of Elasticsearch and modifies the values.yaml and templates to properly clean and manage the new indexes.

Open questions

Is this currently planned somewhere else?

@Stevenpc3 Stevenpc3 added the enhancement New feature or request label Jan 4, 2024
@Stevenpc3
Copy link
Contributor Author

Seeing how the old elasticsearch chart is deprecated and the suggestion is to use ECK now but has license issues to consider.

I suggest doing what we did when we needed to use elasticsearch outside of jaeger which is use the elasticsearch bitnami chart.

Ironically... we were going to use the bitnami jaeger chart but it is woefully under developed compared to other charts.

Stevenpc3 referenced this issue Feb 1, 2024
* Update Jaeger version

Signed-off-by: Mustafa Barış Ege <mbarisege@gmail.com>

* update appVersion to 1.53.0

Signed-off-by: Mustafa Barış Ege <mbarisege@gmail.com>

---------

Signed-off-by: Mustafa Barış Ege <mbarisege@gmail.com>
Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Co-authored-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
@Stevenpc3
Copy link
Contributor Author

helm charts were just updated to 1.53 94950b7.

This implies that I can use elasticsearch 8+ . Any work on ensuring this is true and updateing the chart to point to the new bitnami charts? Bitnami charts have changed so I assume jeager charts would require a number of updates. For example elasticsearch.esConfig is no longer avaialble in the bitnami charts

@dpericaxon
Copy link
Contributor

@Stevenpc3 I took a crack at this and created #554 if you want test out the version by checking my branch and generating a tar, that would be great! (Obviously not in production!)

@Stevenpc3
Copy link
Contributor Author

Stevenpc3 commented Apr 10, 2024

Awesome thanks! I'll try to get to it this week.

Did you get to test esIndexCleaner it other items? I guess they should be fine since those images are in the Jaeger repo and should have been updated to with with elastic 8.

Hopefully is this simple!

@Stevenpc3
Copy link
Contributor Author

Stevenpc3 commented May 22, 2024

So we finally got to test this and it appears to work and esIndexCleaner works. BUT...

This breaks spark. It will throw an error stating that it only supports version 7 of elasticsearch and requires hadoop.

@dpericaxon
Copy link
Contributor

Hey @Stevenpc3 I think you're running into this open issue: jaegertracing/spark-dependencies#137 Theres a suggestion there to make sure to "Use ghcr.io/jaegertracing/spark-dependencies/spark-dependencies:latest instead of the on on docker.io , which is outdated for ages." Maybe try that?

@Stevenpc3
Copy link
Contributor Author

Stevenpc3 commented May 22, 2024

Yeah I'll give it a go tomorrow. I'm just using the default from the chart. If that works then I guess the chart needs updating. This is pulling the image that Jaeger published. I see it was updated so should work jaegertracing/spark-dependencies@a5e1736

If the registry defaults to docker then we likely should update the registry in the chart to point to the right place otherwise it will keep happening for everyone.

Update this https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/values.yaml#L780 to be the correct registry. And also any others that require it so they don't default to the wrong registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants